The _store on each variables view instance is redundant

RESOLVED FIXED in Firefox 23

Status

P3
normal
RESOLVED FIXED
6 years ago
5 months ago

People

(Reporter: vporof, Assigned: vporof)

Tracking

unspecified
Firefox 23
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
We have a _items array since bug 843187. Keeping the _store map as well provides no benefit.
(Assignee)

Comment 1

6 years ago
Created attachment 740845 [details] [diff] [review]
v1

s/items/store and removed the old map.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #740845 - Flags: review?(rcampbell)
(Assignee)

Updated

6 years ago
Priority: -- → P3
Comment on attachment 740845 [details] [diff] [review]
v1

Review of attachment 740845 [details] [diff] [review]:
-----------------------------------------------------------------

good cleanin'!
Attachment #740845 - Flags: review?(rcampbell) → review+
(Assignee)

Comment 3

6 years ago
fx-team is a bit carroty at the momemnt, so inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a0df791c0f8
https://hg.mozilla.org/mozilla-central/rev/7a0df791c0f8
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23

Updated

5 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.