Closed Bug 864802 Opened 7 years ago Closed 7 years ago

The _store on each variables view instance is redundant

Categories

(DevTools :: Debugger, defect, P3)

Product:
DevTools
Component:
Debugger
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 23

People

(Reporter: vporof, Assigned: vporof)

Details

Attachments

(1 file)

v1
12.27 KB, patch
rcampbell
: review+
Details | Diff | Splinter Review 
We have a _items array since bug 843187. Keeping the _store map as well provides no benefit.
Attached patch v1 — — Splinter Review 
s/items/store and removed the old map.
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #740845 - Flags: review?(rcampbell)
Priority: -- → P3
Comment on attachment 740845 [details] [diff] [review]
v1

Review of attachment 740845 [details] [diff] [review]:
-----------------------------------------------------------------

good cleanin'!
Attachment #740845 - Flags: review?(rcampbell) → review+
fx-team is a bit carroty at the momemnt, so inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a0df791c0f8
https://hg.mozilla.org/mozilla-central/rev/7a0df791c0f8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.