Closed Bug 864803 Opened 7 years ago Closed 7 years ago

sutAgent: "Failed to destroy process" on pandaboards

Categories

(Testing Graveyard :: SUTAgent, defect)

x86
Android
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla23

People

(Reporter: gbrown, Assigned: gbrown)

Details

Attachments

(1 file)

Test logs from pandaboards very often show something like:

04-22 16:53:20.734 I/System  ( 1901): Failed to destroy process 4054
04-22 16:53:20.742 I/System  ( 1901): libcore.io.ErrnoException: kill failed: ESRCH (No such process)
04-22 16:53:20.742 I/System  ( 1901): 	at libcore.io.Posix.kill(Native Method)
04-22 16:53:20.742 I/System  ( 1901): 	at libcore.io.ForwardingOs.kill(ForwardingOs.java:77)
04-22 16:53:20.742 I/System  ( 1901): 	at java.lang.ProcessManager$ProcessImpl.destroy(ProcessManager.java:257)
04-22 16:53:20.742 I/System  ( 1901): 	at com.mozilla.SUTAgentAndroid.service.RedirOutputThread.run(RedirOutputThread.java:148)

I think this is harmless -- we are trying to kill a sut-spawned process that ended gracefully -- but I find the messages distracting. Sometimes these messages account for a significant percentage of the logcat...let's get rid of them and make room for other messages in logcat.
If waitFor() completes, there should be no need to call destroy(). See http://developer.android.com/reference/java/lang/Process.html#waitFor%28%29
Attachment #741056 - Flags: review?(jmaher)
Comment on attachment 741056 [details] [diff] [review]
only call destroy on process if process.waitFor does not complete

Review of attachment 741056 [details] [diff] [review]:
-----------------------------------------------------------------

nice cleanup.
Attachment #741056 - Flags: review?(jmaher) → review+
https://hg.mozilla.org/mozilla-central/rev/883df548b014
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.