864803 - sutAgent: "Failed to destroy process" on pandaboards

Status: RESOLVED FIXED

(Testing Graveyard :: SUTAgent, defect)

Description

[Geoff Brown [:gbrown]]

Test logs from pandaboards very often show something like:

04-22 16:53:20.734 I/System  ( 1901): Failed to destroy process 4054
04-22 16:53:20.742 I/System  ( 1901): libcore.io.ErrnoException: kill failed: ESRCH (No such process)
04-22 16:53:20.742 I/System  ( 1901): 	at libcore.io.Posix.kill(Native Method)
04-22 16:53:20.742 I/System  ( 1901): 	at libcore.io.ForwardingOs.kill(ForwardingOs.java:77)
04-22 16:53:20.742 I/System  ( 1901): 	at java.lang.ProcessManager$ProcessImpl.destroy(ProcessManager.java:257)
04-22 16:53:20.742 I/System  ( 1901): 	at com.mozilla.SUTAgentAndroid.service.RedirOutputThread.run(RedirOutputThread.java:148)

I think this is harmless -- we are trying to kill a sut-spawned process that ended gracefully -- but I find the messages distracting. Sometimes these messages account for a significant percentage of the logcat...let's get rid of them and make room for other messages in logcat.

Comment 1

[Geoff Brown [:gbrown]]

Attachment: only call destroy on process if process.waitFor does not complete

If waitFor() completes, there should be no need to call destroy(). See http://developer.android.com/reference/java/lang/Process.html#waitFor%28%29

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 741056 [details] [diff] [review]
only call destroy on process if process.waitFor does not complete

Review of attachment 741056 [details] [diff] [review]:
-----------------------------------------------------------------

nice cleanup.

Comment 3

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/883df548b014

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/883df548b014