864841 - Creating a contact with only "Company" doesn't work

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[alberto.pastor]

STR:

1.- Open Contacts
2.- Create new Contact, only filing the company

Expected:

The contact is shown in the list

Actual:

The contact is not shown

Comment 1

[alberto.pastor]

Not sure where this regression comes from, but happening in master, v1-train and v1.0.1

Comment 2

[Daniel Coloma:dcoloma]

The problem is even worse, after trying to add such a contact, nothing is working properly, e.g. existing contacts disappear, it is now always possible to add new contacts, etc.

Comment 3

[alberto.pastor]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9420

Pointer to Github pull-request

Comment 4

[Joe Cheng [:jcheng] (please needinfo)]

perhaps you want to take this Alberto? thanks

Comment 5

[alberto.pastor]

SOrry, forgot to take it. Patch is already there. Thanks!

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 742035 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9420

Tested on the phone and unit tests passing.

Thanks Alberto

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Landed

https://github.com/mozilla-b2g/gaia/commit/e465d99917b72e16e4f6b4f1e7fdce7b84b152f9

Comment 8

[James Lal [:lightsofapollo]]

I was not able to uplift this bug to v1-train and v1.0.1.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train and v1.0.1, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 e465d99917b72e16e4f6b4f1e7fdce7b84b152f9
  <RESOLVE MERGE CONFLICTS>
  git commit
  git checkout v1.0.1
  git cherry-pick -x $(git log -n1 v1-train --pretty=%H)

Comment 9

[James Lal [:lightsofapollo]]

v1-train: 57adf4a
v1.0.1: 7280a6a

Comment 10

[Delphine Lebédel [:delphine - Use needinfo]]

Verified fixed in v1-train and and v1.0.1