864870 - Reenable narrowing-conversion warnings in MSVC, enable them in clang/gcc

Status: NEW

(Core :: JavaScript Engine, enhancement, P5)

Description

[Jeff Walden [:Waldo]]

We disabled them awhile back in bug 610480 because we thought they were spammy-ish.  But really, they kinda point out issues.  We should fix any instances of the problems, then reenable.  (Or enable, as the case is, for clang/gcc -- -Wconversion, -Wshorten-64-to-32.)

It might be a good idea at the same time to add some helper methods to perform the casts, that verify the casts are safe to perform.  I've been meaning to add these to mfbt but haven't gotten around to it.  Maybe now, ish, is the time to do that.

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Reenable warn-on-dodgy-conversion in js/src

The warning-stream this spews with gcc (at least) is kind of incredible.  It'll take some effort to sort through it all.  A bunch of warnings are likely to be in headers, tho, so I imagine the overall volume can be cut substantially with little effort.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.