Closed Bug 864872 Opened 7 years ago Closed 7 years ago

OdinMonkey: protect all the code pages on Windows

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23
Tracking Status
firefox22 --- fixed
firefox23 --- fixed

People

(Reporter: luke, Assigned: luke)

Details

Attachments

(1 file)

For some bizarre reason, TriggerOperationCallbackForAsmJSCode only protects the first page of executable code.  It should just pass module.functionBytes() like the non-Windows path.
Attached patch patchSplinter Review
Attachment #740912 - Flags: review?(sstangl)
Comment on attachment 740912 [details] [diff] [review]
patch

Review of attachment 740912 [details] [diff] [review]:
-----------------------------------------------------------------

Oh my.
Attachment #740912 - Flags: review?(sstangl) → review+
Comment on attachment 740912 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 840282
User impact if declined: uninterruptible iloop in asm.js code
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): very low
Attachment #740912 - Flags: approval-mozilla-aurora?
Attachment #740912 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/649497c7a2e9
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.