Closed
Bug 864872
Opened 12 years ago
Closed 12 years ago
OdinMonkey: protect all the code pages on Windows
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: luke, Assigned: luke)
Details
Attachments
(1 file)
|
880 bytes,
patch
|
sstangl
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
For some bizarre reason, TriggerOperationCallbackForAsmJSCode only protects the first page of executable code. It should just pass module.functionBytes() like the non-Windows path.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #740912 -
Flags: review?(sstangl)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 740912 [details] [diff] [review]
patch
Review of attachment 740912 [details] [diff] [review]:
-----------------------------------------------------------------
Oh my.
Attachment #740912 -
Flags: review?(sstangl) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
|
Assignee | |
Comment 4•12 years ago
|
||
Comment on attachment 740912 [details] [diff] [review]
patch
[Approval Request Comment]
Bug caused by (feature/regressing bug #): 840282
User impact if declined: uninterruptible iloop in asm.js code
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): very low
Attachment #740912 -
Flags: approval-mozilla-aurora?
|
||
Updated•12 years ago
|
Attachment #740912 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
|
|
||
Comment 6•12 years ago
|
||
status-firefox22:
--- → fixed
status-firefox23:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•