864892 - dom/browser-element/BrowserElementPanning.js kinetic panning does not work with hand made touch events

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Let's normalize them.

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 740939 [details] [diff] [review]
Patch

Review of attachment 740939 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/browser-element/BrowserElementPanning.js
@@ +681,5 @@
>  
> +  _getTime: function kp_getTime(time) {
> +    // Touch events generated by the platform or hand-made have different
> +    // timestamps values. Let's normalize them.
> +    if (time > 2 * Date.now()) {

that's quite... ugly no? time > Date.now() is not enough?

@@ +685,5 @@
> +    if (time > 2 * Date.now()) {
> +      return Math.floor(time / 1000);                                          
> +    } else {                                                                   
> +      return time;
> +    }     

Nit: You have a bunch of trailing whitespace at almost every line.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

The right fix for this would be bug 77992. In the meantime I will address your comments and land that.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Comment 5

[[:fabrice] Fabrice Desré]

Comment on attachment 747940 [details] [diff] [review]
Patch

Review of attachment 747940 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/browser-element/BrowserElementPanning.js
@@ +681,5 @@
>  
>    momentums: [],
>    record: function kp_record(delta, timestamp) {
> +    this.momentums.push({ 'time': this._getTime(timestamp),
> +                        'dx' : delta.x, 'dy' : delta.y });

nit: align 'dx' with 'time'

@@ +686,5 @@
>      this.distance.add(delta.x, delta.y);
>    },
>  
> +  _getTime: function kp_getTime(time) {
> +    // Touch events generated by the platform or hand-made have are defined in

nit: s/have//

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://hg.mozilla.org/projects/birch/rev/1702ed606df7

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1702ed606df7