Closed
Bug 864899
Opened 12 years ago
Closed 12 years ago
PeerConnectionImpl.cpp:369:1: warning: ‘void sipcc::Warn(JSContext*, const nsCString&)’ defined but not used [-Wunused-function]
Categories
(Core :: WebRTC, defect)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
(Whiteboard: [WebRTC] [blocking-webrtc-] [qa-])
Attachments
(1 file)
|
1.61 KB,
patch
|
jib
:
review+
|
Details | Diff | Splinter Review |
GCC 4.8 build warning in mozilla-central:
{
media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp:369:1: warning: ‘void sipcc::Warn(JSContext*, const nsCString&)’ defined but not used [-Wunused-function]
}
The last usages of this function were removed in bug 855769's cset:
https://hg.mozilla.org/mozilla-central/rev/915ad1e8a9bb#l3.22
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #740946 -
Flags: review?(jib)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 740946 [details] [diff] [review]
fix: remove function
Review of attachment 740946 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm. Thanks!
|
|
Assignee | |
Comment 3•12 years ago
|
||
[I assume that indicates an r+? The flag is still set at "?", currently.]
Thanks!
|
|
||
Updated•12 years ago
|
Attachment #740946 -
Flags: review?(jib) → review+
|
|
||
Comment 4•12 years ago
|
||
Yes sorry. :-)
|
||
Updated•12 years ago
|
Whiteboard: [WebRTC] [blocking-webrtc-]
|
|
||
Updated•12 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 5•12 years ago
|
||
Flags: in-testsuite-
Keywords: checkin-needed
|
||
Comment 6•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
|
||
Updated•12 years ago
|
Whiteboard: [WebRTC] [blocking-webrtc-] → [WebRTC] [blocking-webrtc-] [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•