Closed Bug 864899 Opened 7 years ago Closed 7 years ago

PeerConnectionImpl.cpp:369:1: warning: ‘void sipcc::Warn(JSContext*, const nsCString&)’ defined but not used [-Wunused-function]

Categories

(Core :: WebRTC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

(Whiteboard: [WebRTC] [blocking-webrtc-] [qa-])

Attachments

(1 file)

GCC 4.8 build warning in mozilla-central:
{
media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp:369:1: warning: ‘void sipcc::Warn(JSContext*, const nsCString&)’ defined but not used [-Wunused-function]
}

The last usages of this function were removed in bug 855769's cset:
 https://hg.mozilla.org/mozilla-central/rev/915ad1e8a9bb#l3.22
Attachment #740946 - Flags: review?(jib)
Comment on attachment 740946 [details] [diff] [review]
fix: remove function

Review of attachment 740946 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm. Thanks!
[I assume that indicates an r+?  The flag is still set at "?", currently.]

Thanks!
Attachment #740946 - Flags: review?(jib) → review+
Whiteboard: [WebRTC] [blocking-webrtc-]
https://hg.mozilla.org/mozilla-central/rev/5c7e9f21c920
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Whiteboard: [WebRTC] [blocking-webrtc-] → [WebRTC] [blocking-webrtc-] [qa-]
You need to log in before you can comment on or make changes to this bug.