If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

PeerConnectionImpl.cpp:369:1: warning: ‘void sipcc::Warn(JSContext*, const nsCString&)’ defined but not used [-Wunused-function]

RESOLVED FIXED in mozilla23

Status

()

Core
WebRTC
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks: 1 bug)

Trunk
mozilla23
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [WebRTC] [blocking-webrtc-] [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
GCC 4.8 build warning in mozilla-central:
{
media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp:369:1: warning: ‘void sipcc::Warn(JSContext*, const nsCString&)’ defined but not used [-Wunused-function]
}

The last usages of this function were removed in bug 855769's cset:
 https://hg.mozilla.org/mozilla-central/rev/915ad1e8a9bb#l3.22
(Assignee)

Comment 1

5 years ago
Created attachment 740946 [details] [diff] [review]
fix: remove function
Attachment #740946 - Flags: review?(jib)
Comment on attachment 740946 [details] [diff] [review]
fix: remove function

Review of attachment 740946 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm. Thanks!
(Assignee)

Comment 3

5 years ago
[I assume that indicates an r+?  The flag is still set at "?", currently.]

Thanks!
Attachment #740946 - Flags: review?(jib) → review+
Yes sorry. :-)

Updated

5 years ago
Whiteboard: [WebRTC] [blocking-webrtc-]
Keywords: checkin-needed
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c7e9f21c920
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5c7e9f21c920
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23

Updated

5 years ago
Whiteboard: [WebRTC] [blocking-webrtc-] → [WebRTC] [blocking-webrtc-] [qa-]
You need to log in before you can comment on or make changes to this bug.