864928 - Remove ScriptAnalysis::analyzeTypes (for real this time)

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Brian Hackett [Laid off!]]

Bug 804676 removed the main consumer of the type information produced by the constraints added in analyzeTypes().  There are a few remaining uses, however.  JM+TI still uses analyzeTypes, and the type info is used when analyzing definite properties in new scripts.  When these are no longer dependencies, analyzeTypes and the associated machinery can be removed entirely.

Comment 1

[Brian Hackett [Laid off!]]

Attachment: patch

7 files changed, 21 insertions(+), 2442 deletions(-)

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 798583 [details] [diff] [review]
patch

Review of attachment 798583 [details] [diff] [review]:
-----------------------------------------------------------------

Beautiful!

::: js/src/jsanalyze.h
@@ +836,3 @@
>          bool hasPropertyReadTypes;
>          uint32_t propertyReadIndex;
>          TypeInferenceState(JSContext *cx)

I think you can remove TypeInferenceState as well.

Comment 3

[Jan de Mooij [:jandem]]

Is the plan to eventually make the arguments analysis work on the MIR as well? Once we do that we can remove the SSA / lifetime analysis, then we can port IonBuilder to use Baseline's BytecodeAnalysis class (destroyed immediately after compilation) and then we can remove ScriptAnalysis completely, right? Very cool :)

Comment 4

[Brian Hackett [Laid off!]]

(In reply to Jan de Mooij [:jandem] from comment #3)
> Is the plan to eventually make the arguments analysis work on the MIR as
> well? Once we do that we can remove the SSA / lifetime analysis, then we can
> port IonBuilder to use Baseline's BytecodeAnalysis class (destroyed
> immediately after compilation) and then we can remove ScriptAnalysis
> completely, right? Very cool :)

Yes, this is the plan.  No ETA at the moment since it's not really blocking anything --- I did bug 906788 to unblock work on running IonBuilder off thread.

Comment 5

[Brian Hackett [Laid off!]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b2ad58e8b248

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b2ad58e8b248