Closed
Bug 865183
Opened 12 years ago
Closed 12 years ago
Allow chrome callers to call navigator.getUserMediaDevices
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: ted, Assigned: ted)
References
Details
Attachments
(1 file)
|
1.20 KB,
patch
|
bzbarsky
:
review+
smaug
:
review+
|
Details | Diff | Splinter Review |
Currently navigator.getUserMediaDevices checks that the window it was called from is a chrome document. This means you can't use SpecialPowers.wrap(navigator).getUserMediaDevices to call this method from a Mochitest. bz suggested I could change this to IsCallerChrome instead to make this work. This patch does that, and works for my purposes (for bug 815002).
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #741256 -
Flags: review?(bzbarsky)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 741256 [details] [diff] [review]
Allow chrome callers to call navigator.getUserMediaDevices
This makes sense to me, but I'd like smaug to look, just in case the original patch did things the way it did for a reason.....
Attachment #741256 -
Flags: review?(bzbarsky)
Attachment #741256 -
Flags: review?(bugs)
Attachment #741256 -
Flags: review+
|
||
Comment 3•12 years ago
|
||
Comment on attachment 741256 [details] [diff] [review]
Allow chrome callers to call navigator.getUserMediaDevices
Nah, it was just a mistake in the original patch passing my eyes.
Attachment #741256 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•