Closed Bug 865197 Opened 12 years ago Closed 12 years ago

Follow-up 861846 - Unit test fixed and added a new one

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System
Platform:
x86
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g18 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
b2g18 --- fixed

People

(Reporter: crdlc, Assigned: crdlc)

References

Details

Attachments

(1 file)

Patch v1
188 bytes, text/html
julienw
: review+
Details
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Attached file Patch v1 —
Attachment #741271 - Flags: review?(felash)
Depends on: 861846
reviewed on github
implemented the comments, thanks
one last change and we're good !
Comment on attachment 741271 [details] Patch v1 r=me master: 5d150dee984167b06ff521c2b57a72f0d97e0ea9
Attachment #741271 - Flags: review?(felash) → review+
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
James, could you please uplift this to both branches (hoping this will work without conflict) ? this is a=npotb
Flags: needinfo?(jlal)
ok, sorry about that crdlc, I just see that it breaks the linter. I'm reverting the patch then...
reverting commit: master: 24118088f13ba801cb721fe9681a8857556afbc2
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Should I create other pr?
what is the problem? I am investigating in my laptop with lint tool and I don't have problems :(
Maybe I am wrong but my pc says MacCrdlc:gaia crdlc$ gjslint apps/system/test/unit/cards_view_test.js 1 files checked, no errors found. MacCrdlc:gaia crdlc$ gjslint apps/system/test/unit/mock_window_manager.js 1 files checked, no errors found. Thanks
ok, you're completely right, sorry about that. Will land it again.
new master: 610a684aad80f4d1a4576b5dc1e42dfaba055346
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Sorry Julien does not apply =/
Flags: needinfo?(jlal) → needinfo?(felash)
The patch does not apply because the tests in Bug 847241 were not uplifted. I've no time for this now so I'll skip it for now, keeping need info though.
Flags: needinfo?(felash)
Flags: needinfo?(felash)
a=npotb v1-train: 9841cfc141e3f849aba780592e02a482b17eb570 will not uplift to v1.0.1 as the tests are broken there and there are more conflicts.
status-b2g18: --- → fixed
Flags: needinfo?(felash)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: