865218 - application/x-moz-keywordsearch should still be used in keyword search (nsDefaultURIFixup.cpp)

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Mike Kaply [:mkaply]]

I understand the concept behind the purpose flag, and it's a good idea, but by removing application/x-moz-keywordsearch it prevents really basic things like having keyword search map to google's "I'm feeling lucky". Not every server can just use a keyword to decide what to do (especially for existing services). It might be a different URL.

Looking at the keyword fixup code, there was no reason to remove application/x-moz-keywordsearch. 

The code in search should have just been changed to not fail if the specific type wasn't found.

That way you could support the old code and still have the new code.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Use keyword if available

This is a simple patch that checks to see if the search engine supports the keyword and if it is there, use it.

This allows existing search engines to work.

This won't affect the builtin search engines because keyword has been removed.

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Google Feeling Lucky example

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Google Feeling Lucky example

Comment 4

[Mike Kaply [:mkaply]]

To use this search engine, open scratchpad and type:

window.external.AddSearchProvider("https://bug865218.bugzilla.mozilla.org/attachment.cgi?id=741388");

Comment 5

[Ben Bucksch (:BenB)]

This is a good change. I agreed with Mike's reasoning: I understand the recent change, but it no longer supports certain URL styles.
http://mycroftproject.com/ has over 23000 OSDs (!). Some of these are bound to be broken by this changes.
If we can support both old and new, that's certainly better.

Comment 6

[Mike Kaply [:mkaply]]

Any thoughts on this gavin?

Comment 7

[:Gavin Sharp [email: [e-mail]]]

I'm kind of on the fence. I guess it's a valid use case, but I hate to have these kind of gross hacks that will likely benefit few people in practice.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 741334 [details] [diff] [review]
Use keyword if available

I guess the net cost is relatively low. You can use NS_NAMED_LITERAL_STRING to avoid duplicating the "application/x-moz-keywordsearch" string.

Can you document this on https://developer.mozilla.org/en-US/docs/Creating_OpenSearch_plugins_for_Firefox ?

Comment 9

[Mike Kaply [:mkaply]]

Attachment: Patch for checkin

This is the final patch for check with NS_NAMED_LITERAL_STRING

Am I free to check this in at this point?

Comment 10

[Mike Kaply [:mkaply]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d62ad9a19c33

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d62ad9a19c33