865287 - [sms] [unit tests] sms tests should use the real html from index.html

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Corey Frang [:gnarf]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_3) AppleWebKit/537.31 (KHTML, like Gecko) Chrome/26.0.1410.65 Safari/537.31

Steps to reproduce:

The sms_test suite currently checks a bunch of html/template related things, however it is using entirely mocked data, which can diverge from the content of the index.html.  We should make the unit tests load in the html from index.html

Comment 1

[Corey Frang [:gnarf]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/9384

Comment 2

[Corey Frang [:gnarf]]

Comment on attachment 741356 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/9384

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):
String or UUID changes made by this patch:

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 741356 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/9384

reviewed on the PR github

we'll try the approach and see if it works correctly. In the end I'd like to have this integrated in the main test-agent so I'd like a feedback from James too.

Comment 4

[James Lal [:lightsofapollo]]

Comment on attachment 741356 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/9384

Approach looks good to me but I don't think we should upstream this to test-agent but just to the shared test code in test_apps/test-agent/...

test-agent does alot right now... In my ideal world it would simply focus on running and aggregating test results and the rest (including how to include files) is up to the developer (our gaia stuff).

Comment 5

[Julien Wajsberg [:julienw]]

Comment on attachment 741356 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/9384

r=me if you rename the new file to "load_body_html_helper.js".

Comment 6

[Julien Wajsberg [:julienw]]

master: e150fb80302bebef676cf0e972bd17f83de97993

Comment 7

[Julien Wajsberg [:julienw]]

I'll uplift it because it's npotb.

Comment 8

[Julien Wajsberg [:julienw]]

a=npotb
v1-train: 85f283d15cebb50d0bd5119c17cf98f83f4f543c