Closed
Bug 865312
Opened 12 years ago
Closed 12 years ago
DownloadsIndicatorView.onDragLeave is not a function
Categories
(Firefox :: Downloads Panel, defect)
Firefox
Downloads Panel
Tracking
()
RESOLVED
FIXED
Firefox 24
People
(Reporter: mak, Assigned: brennan.brisad)
Details
(Whiteboard: [good-first-bug][mentor=mak][lang=js])
Attachments
(1 file)
|
2.19 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
drag something over the downloads button, and then out of it, will get "DownloadsIndicatorView.onDragLeave is not a function" error.
Indeed we have onDragExit there, though it's also empty... both should be removed.
|
Assignee | |
Comment 1•12 years ago
|
||
Hi, I've attached a patch where I simply removed the two functions.
Attachment #745542 -
Flags: review?
|
|
Assignee | |
Updated•12 years ago
|
Attachment #745542 -
Flags: review? → review?(mak77)
|
Reporter | |
Comment 2•12 years ago
|
||
Comment on attachment 745542 [details] [diff] [review]
Remove onDragLeave and onDragExit from DownloadsIndicatorView
Review of attachment 745542 [details] [diff] [review]:
-----------------------------------------------------------------
Very much appreciated :)
please set checkin-needed keyword if you don't have commit permission
Attachment #745542 -
Flags: review?(mak77) → review+
|
||
Updated•12 years ago
|
Assignee: nobody → brennan.brisad
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 3•12 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
You need to log in
before you can comment on or make changes to this bug.
Description
•