Closed Bug 865312 Opened 7 years ago Closed 6 years ago

DownloadsIndicatorView.onDragLeave is not a function

Categories

(Firefox :: Downloads Panel, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 24

People

(Reporter: mak, Assigned: brennan.brisad)

Details

(Whiteboard: [good-first-bug][mentor=mak][lang=js])

Attachments

(1 file)

drag something over the downloads button, and then out of it, will get "DownloadsIndicatorView.onDragLeave is not a function" error.

Indeed we have onDragExit there, though it's also empty... both should be removed.
Hi, I've attached a patch where I simply removed the two functions.
Attachment #745542 - Flags: review?
Attachment #745542 - Flags: review? → review?(mak77)
Comment on attachment 745542 [details] [diff] [review]
Remove onDragLeave and onDragExit from DownloadsIndicatorView

Review of attachment 745542 [details] [diff] [review]:
-----------------------------------------------------------------

Very much appreciated :)

please set checkin-needed keyword if you don't have commit permission
Attachment #745542 - Flags: review?(mak77) → review+
Assignee: nobody → brennan.brisad
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a7b3ef7ded5c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
You need to log in before you can comment on or make changes to this bug.