The default bug view has changed. See this FAQ.

DownloadsIndicatorView.onDragLeave is not a function

RESOLVED FIXED in Firefox 24

Status

()

Firefox
Downloads Panel
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mak, Assigned: Michael Brennan)

Tracking

unspecified
Firefox 24
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good-first-bug][mentor=mak][lang=js])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
drag something over the downloads button, and then out of it, will get "DownloadsIndicatorView.onDragLeave is not a function" error.

Indeed we have onDragExit there, though it's also empty... both should be removed.
(Assignee)

Comment 1

4 years ago
Created attachment 745542 [details] [diff] [review]
Remove onDragLeave and onDragExit from DownloadsIndicatorView

Hi, I've attached a patch where I simply removed the two functions.
Attachment #745542 - Flags: review?
(Assignee)

Updated

4 years ago
Attachment #745542 - Flags: review? → review?(mak77)
(Reporter)

Comment 2

4 years ago
Comment on attachment 745542 [details] [diff] [review]
Remove onDragLeave and onDragExit from DownloadsIndicatorView

Review of attachment 745542 [details] [diff] [review]:
-----------------------------------------------------------------

Very much appreciated :)

please set checkin-needed keyword if you don't have commit permission
Attachment #745542 - Flags: review?(mak77) → review+

Updated

4 years ago
Assignee: nobody → brennan.brisad
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/a7b3ef7ded5c
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a7b3ef7ded5c
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 24
You need to log in before you can comment on or make changes to this bug.