Last Comment Bug 865312 - DownloadsIndicatorView.onDragLeave is not a function
: DownloadsIndicatorView.onDragLeave is not a function
Status: RESOLVED FIXED
[good-first-bug][mentor=mak][lang=js]
:
Product: Firefox
Classification: Client Software
Component: Downloads Panel (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Firefox 24
Assigned To: Michael Brennan
:
: :Paolo Amadini
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-24 09:33 PDT by Marco Bonardo [::mak]
Modified: 2013-05-13 13:46 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Remove onDragLeave and onDragExit from DownloadsIndicatorView (2.19 KB, patch)
2013-05-04 07:07 PDT, Michael Brennan
mak77: review+
Details | Diff | Splinter Review

Description Marco Bonardo [::mak] 2013-04-24 09:33:16 PDT
drag something over the downloads button, and then out of it, will get "DownloadsIndicatorView.onDragLeave is not a function" error.

Indeed we have onDragExit there, though it's also empty... both should be removed.
Comment 1 Michael Brennan 2013-05-04 07:07:57 PDT
Created attachment 745542 [details] [diff] [review]
Remove onDragLeave and onDragExit from DownloadsIndicatorView

Hi, I've attached a patch where I simply removed the two functions.
Comment 2 Marco Bonardo [::mak] 2013-05-09 05:52:04 PDT
Comment on attachment 745542 [details] [diff] [review]
Remove onDragLeave and onDragExit from DownloadsIndicatorView

Review of attachment 745542 [details] [diff] [review]:
-----------------------------------------------------------------

Very much appreciated :)

please set checkin-needed keyword if you don't have commit permission
Comment 3 Ryan VanderMeulen [:RyanVM] 2013-05-13 06:24:35 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/a7b3ef7ded5c
Comment 4 Ryan VanderMeulen [:RyanVM] 2013-05-13 13:46:31 PDT
https://hg.mozilla.org/mozilla-central/rev/a7b3ef7ded5c

Note You need to log in before you can comment on or make changes to this bug.