Closed Bug 865325 Opened 12 years ago Closed 12 years ago

"organizer is null"

Categories

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

Product:
Calendar
Component:
E-mail based Scheduling (iTIP/iMIP)
Version:
Lightning 1.9.1
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mss, Assigned: rkent)

References

Details

Attachments

(2 files)

Just stupidly catch the error and work around
1.52 KB, patch
Fallen
: review+
Fallen
: approval-calendar-aurora+
Fallen
: approval-calendar-beta+
Fallen
: approval-calendar-esr+
Details | Diff | Splinter Review
organizernull.eml
8.55 KB, message/rfc822
Details
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:20.0) Gecko/20100101 Firefox/20.0 Build ID: 20130329030832 Steps to reproduce: Received a mail that somebody accepted an invitation: Return-Path: <dirk.jjjjjj-zzzzzzzzzz@example.net> Delivered-To: <zzzzzzw@deliver2.example.net> Received: from deliver2 ([10.0.2.2]) by deliver2.example.net (Dovecot) with LMTP id JZI1EBw9dVErMwAACHSP1g for <zzzzzzw@deliver2.example.net>; Mon, 22 Apr 2013 15:39:17 +0200 Received: from smtp-map-3.example.net (smtp-map-3.example.net [131.169.56.68]) by deliver2 (DDDD_DELIVER_DELIVER_2) with ESMTP id 99D8B43ACB for <zzzzzzw@mail.example.net>; Mon, 22 Apr 2013 15:39:17 +0200 (MEST) Received: from spamfilter3.example.net (spamfilter3.example.net [131.169.56.144]) by smtp-map-3.example.net (DDDD_MAP_3) with ESMTP id 6ED6A10F8 for <wolfgang.zzzzzz@example.net>; Mon, 22 Apr 2013 15:39:17 +0200 (MEST) Received: from spamfilter3.example.net (localhost [127.0.0.1]) by localhost.domain.tld (DDDD MTA) with ESMTP id D7DB318E776 for <wolfgang.zzzzzz@example.net>; Mon, 22 Apr 2013 15:39:15 +0200 (CEST) X-Spam-Virus: No X-Spam-TaggedAsSpamByDddd: NO X-Spam-Checker-Version: SpamAssassin 3.2.5-crocodial_spamlock_2.00_1 on spamfilter3.example.net NO -4.7 X-Spam-Level: X-Spam-Status: No, hits=-4.7 required=5.0 autolearn=ham tests=AWL,BAYES_00, DDDD_NOT_VIA_GW,HTML_MESSAGE,HTML_SHORT_LENGTH,MIME_HTML_MOSTLY, TVD_SPACE_RATIO,UNPARSEABLE_RELAY version=3.2.5-crocodial_spamlock_2.00_1 Received: from ZITSWEEP2.win.example.net (lb-56-26.example.net [131.169.56.26]) by spamfilter3.example.net (DDDD MTA) with ESMTP id C99C618E766 for <wolfgang.zzzzzz@example.net>; Mon, 22 Apr 2013 15:39:15 +0200 (CEST) Received: from smtp-intra-3.example.net (lb-40-26.example.net) by ZITSWEEP2.win.example.net (Clearswift SMTPRS 5.4.1) with ESMTP id <Tab3eceec7883a9616015ec@ZITSWEEP2.win.example.net> for <wolfgang.zzzzzz@example.net>; Mon, 22 Apr 2013 15:39:15 +0200 Received: from zimbratest.example.net (zimbratest.example.net [131.169.72.254]) by smtp-intra-3.example.net (DDDD-INTRA-3) with ESMTP id 73DBC1412 for <wolfgang.zzzzzz@example.net>; Mon, 22 Apr 2013 15:39:15 +0200 (MEST) From: Dirk Jahnke-Zumbusch <dirk.jjjjjj-zzzzzzzzzz@example.net> To: "Zeikat, Wolfgang" <wolfgang.zzzzzz@example.net> Subject: Accepted: mailproject-Schulung Date: Mon, 22 Apr 2013 15:39:15 +0200 (CEST) Message-ID: <c75d8d73.00000120.0000000a@ZITPCX17483.example.net> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 14.0 X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraConnectorForOutlook/8.0.3.780) Thread-Index: SdPnY+rrnQ7RPdBoBVjO6AB4kfO7aA== Sensitivity: Private Content-Type: multipart/alternative; boundary="------------Boundary-00=_FLSN4Y7kX93yP9uUPRhg" Thread-Topic: mailproject-Schulung --------------Boundary-00=_FLSN4Y7kX93yP9uUPRhg Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 --------------Boundary-00=_FLSN4Y7kX93yP9uUPRhg Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <=21DOCTYPE HTML PUBLIC =22-//W3C//DTD HTML 3.2//EN=22> <HTML><HEAD><META HTTP-EQUIV=3D=22Content-Type=22 CONTENT=3D=22text/html; = charset=3Dutf-8=22> </HEAD> <BODY></BODY></HTML> --------------Boundary-00=_FLSN4Y7kX93yP9uUPRhg Content-Type: text/calendar; method=REPLY; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: de BEGIN:VCALENDAR PRODID:-//Microsoft Corporation//Outlook 14.0 MIMEDIR//EN VERSION:2.0 METHOD:REPLY X-MS-OLK-FORCEINSPECTOROPEN:TRUE BEGIN:VTIMEZONE TZID:W. Europe Standard Time BEGIN:STANDARD DTSTART:16011028T030000 RRULE:FREQ=YEARLY;BYDAY=-1SU;BYMONTH=10 TZOFFSETFROM:+0200 TZOFFSETTO:+0100 END:STANDARD BEGIN:DAYLIGHT DTSTART:16010325T020000 RRULE:FREQ=YEARLY;BYDAY=-1SU;BYMONTH=3 TZOFFSETFROM:+0100 TZOFFSETTO:+0200 END:DAYLIGHT END:VTIMEZONE BEGIN:VEVENT ATTENDEE;PARTSTAT=ACCEPTED:mailto:dirk.jjjjjj-zzzzzzzzzz@example.net CLASS:PRIVATE CREATED:20130422T133914Z DTEND;TZID="W. Europe Standard Time":20130424T150000 DTSTAMP:20130422T133914Z DTSTART;TZID="W. Europe Standard Time":20130424T100000 LAST-MODIFIED:20130422T133914Z LOCATION:2b/104 PRIORITY:5 SEQUENCE:0 SUMMARY;LANGUAGE=de:Accepted: mailproject-Schulung TRANSP:OPAQUE UID:040000008200E00074C5B7101A82E0080000000050D1AC95693FCE01000000000000000 010000000875AC4576A38724C97A89D7E5C7A44E6 X-MICROSOFT-CDO-BUSYSTATUS:BUSY X-MICROSOFT-CDO-IMPORTANCE:1 X-MS-OLK-AUTOFILLLOCATION:FALSE X-MS-OLK-CONFTYPE:0 END:VEVENT END:VCALENDAR --------------Boundary-00=_FLSN4Y7kX93yP9uUPRhg-- Actual results: A blue bar told me "This message contains an event that this version of Lightning cannot process." The Error Console tells me Timestamp: 04/24/2013 06:30:49 PM Error: organizer is null Source File: file:///~/.thunderbird/dsyx31yc.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/components/lightningTextCalendarConverter.js Line: 78 The code in question is getItipHeader: function getItipHeader(aItipItem) { let header; if (aItipItem) { let item = aItipItem.getItemList({})[0]; let summary = item.getProperty("SUMMARY") || ""; let organizer = item.organizer; // <= let organizerString = organizer.toString(); if (organizer.commonName) { organizerString = organizer.commonName; } Expected results: Everything should be fine any dandy even if an ORGANIZOR-less ICS file is invalid.
I can confirm this on an event I just received. Exactly the same massage in the console. Thunderbird 24 + Lightning 2.6
I've also seen this, in my case in a test message that I received originally though ExQuilla (my email addon for EWS). If it was just me I would leave it unconfirmed, but with the other reports let's call it NEW
Status: UNCONFIRMED → NEW
Ever confirmed: true
I doubt if this is the best fix, but it does at least fix the symptom so that a message with no organizer does not display as blank.
Attachment #812843 - Flags: review?(philipp)
Comment on attachment 812843 [details] [diff] [review] Just stupidly catch the error and work around Review of attachment 812843 [details] [diff] [review]: ----------------------------------------------------------------- ::: calendar/lightning/components/lightningTextCalendarConverter.js @@ +82,2 @@ > organizerString = organizer.commonName; > + } catch (e) {} Untested but this should be able to be just let organizerString = (organizer) ? (organizer.commonName || organizer.toString()) : "";
Attached file organizernull.eml —
Sample mail that causes this. (Not an invitation, but an attached event.) It displays alright, but it won't be automatically ever marked as read.
Assignee: nobody → kent
Status: NEW → ASSIGNED
Comment on attachment 812843 [details] [diff] [review] Just stupidly catch the error and work around Review of attachment 812843 [details] [diff] [review]: ----------------------------------------------------------------- r=philipp, sorry for the delay. ::: calendar/lightning/components/lightningTextCalendarConverter.js @@ +82,2 @@ > organizerString = organizer.commonName; > + } catch (e) {} Magnus' suggestion sound good to me.
Attachment #812843 - Flags: review?(philipp) → review+
Pushed https://hg.mozilla.org/comm-central/rev/4bd351dfc76a with Magnus' suggestions.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.0
Greetings, This may be a stupid question, but I was just wondering how the mere mortals might be able to get access to this fix before v.3.0?? Luigi
Flags: needinfo?(kent)
I don't have a good feel for how prevalent this issue is, nor do I have a good feeling for the release cycle of Lightning. Phillip, should this be pushed to comm-esr24?
Flags: needinfo?(kent) → needinfo?(philipp)
I missed a couple meetings (albeit short notice ones) because of it, so it is quite prevalent for me. I noticed a few other users on other forums also had this issue, but I don't know how widespread it may be (I've seen some posts for this as early as 2007). For me, this error just crept in recently, but I can't pinpoint exactly what did it. Been using Thunderbird/Lightning for years, with many successful calendar events, and I've never seen this error. Thanks for replying, and apologies that I am not a developer,perhaps I should not post here.
Luigi: you should definitely be posting here. By raising the issue, you make it much more likely that this will get pushed into current releases of Lightning.
Attachment #812843 - Flags: approval-calendar-release?(philipp)
Attachment #812843 - Flags: approval-calendar-beta?(philipp)
Attachment #812843 - Flags: approval-calendar-aurora?(philipp)
Comment on attachment 812843 [details] [diff] [review] Just stupidly catch the error and work around This looks safe enough to take for 2.6.4
Attachment #812843 - Flags: approval-calendar-release?(philipp)
Attachment #812843 - Flags: approval-calendar-release+
Attachment #812843 - Flags: approval-calendar-beta?(philipp)
Attachment #812843 - Flags: approval-calendar-beta+
Attachment #812843 - Flags: approval-calendar-aurora?(philipp)
Attachment #812843 - Flags: approval-calendar-aurora+
Blocks: ltn264
Flags: needinfo?(philipp)
I'm using 2.6.4 (TB 24.3.0) and the error is still present :(
Same issue here with 2.6.4, the fix does not seem to be in this version...
Pushed to comm-esr24: http://hg.mozilla.org/releases/comm-esr24/rev/36e1710dbca8
Target Milestone: 3.0 → 2.6.5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: