As explained in bug 837351, a localization comment explaining what %1$S stands for would be useful for localizers. BlockMixedDisplayContent = Blocked loading mixed display content "%1$S" BlockMixedActiveContent = Blocked loading mixed active content "%1$S"
> Who should review this? Good question, not sure if you need a review considering it's just adding a comment. I think that a single comment would be enough (at least it's what they do in other files, e.g. http://hg.mozilla.org/mozilla-central/file/690b5e0f6562/browser/locales/en-US/chrome/browser/browser.properties) # LOCALIZATION NOTE (BlockMixedDisplayContent, BlockMixedActiveContent): # "%1$S" is the URI of the blocked mixed content resource
Created attachment 742040 [details] [diff] [review] Patch 2 Don't repeat the same comment for two consecutive localization strings.
Created attachment 742047 [details] [diff] [review] Patch 2.1 Don't repeat the same comment for two consecutive localization strings (posted wrong patch in last attachment accidentally). Olli, I r?'ed you because you reviewed the patch where these messages were added in bug 837351. This patch just adds a comment for the benefit of the localizers.
4 years ago