The default bug view has changed. See this FAQ.

Add a localization comment for BlockMixedDisplayContent and BlockMixedActiveContent

RESOLVED FIXED in mozilla23

Status

()

Core
Security
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: flod, Assigned: grobinson)

Tracking

Trunk
mozilla23
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

4 years ago
As explained in bug 837351, a localization comment explaining what %1$S stands for would be useful for localizers.

BlockMixedDisplayContent = Blocked loading mixed display content "%1$S"
BlockMixedActiveContent = Blocked loading mixed active content "%1$S"
(Assignee)

Updated

4 years ago
Assignee: nobody → grobinson
(Assignee)

Comment 1

4 years ago
Created attachment 741919 [details] [diff] [review]
Patch 1

Who should review this?
(Reporter)

Comment 2

4 years ago
> Who should review this?
Good question, not sure if you need a review considering it's just adding a comment.

I think that a single comment would be enough (at least it's what they do in other files, e.g. http://hg.mozilla.org/mozilla-central/file/690b5e0f6562/browser/locales/en-US/chrome/browser/browser.properties)

# LOCALIZATION NOTE (BlockMixedDisplayContent, BlockMixedActiveContent): 
# "%1$S" is the URI of the blocked mixed content resource
(Assignee)

Comment 3

4 years ago
Created attachment 742040 [details] [diff] [review]
Patch 2

Don't repeat the same comment for two consecutive localization strings.
Attachment #741919 - Attachment is obsolete: true
Attachment #742040 - Flags: review?
(Assignee)

Comment 4

4 years ago
Created attachment 742047 [details] [diff] [review]
Patch 2.1

Don't repeat the same comment for two consecutive localization strings (posted wrong patch in last attachment accidentally).

Olli, I r?'ed you because you reviewed the patch where these messages were added in bug 837351. This patch just adds a comment for the benefit of the localizers.
Attachment #742040 - Attachment is obsolete: true
Attachment #742040 - Flags: review?
Attachment #742047 - Flags: review?(bugs)
Attachment #742047 - Flags: review?(bugs) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf1a44d938bf
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/bf1a44d938bf
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.