Last Comment Bug 865344 - Add a localization comment for BlockMixedDisplayContent and BlockMixedActiveContent
: Add a localization comment for BlockMixedDisplayContent and BlockMixedActiveC...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Security (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla23
Assigned To: Garrett Robinson [:grobinson]
:
: David Keeler [:keeler] (use needinfo?)
Mentors:
Depends on: 837351
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-24 10:29 PDT by Francesco Lodolo [:flod] (mostly out of office until Dec 19)
Modified: 2013-04-26 18:41 PDT (History)
2 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch 1 (1.62 KB, patch)
2013-04-25 10:05 PDT, Garrett Robinson [:grobinson]
no flags Details | Diff | Splinter Review
Patch 2 (11.07 KB, patch)
2013-04-25 14:31 PDT, Garrett Robinson [:grobinson]
no flags Details | Diff | Splinter Review
Patch 2.1 (1.33 KB, patch)
2013-04-25 14:35 PDT, Garrett Robinson [:grobinson]
bugs: review+
Details | Diff | Splinter Review

Description Francesco Lodolo [:flod] (mostly out of office until Dec 19) 2013-04-24 10:29:23 PDT
As explained in bug 837351, a localization comment explaining what %1$S stands for would be useful for localizers.

BlockMixedDisplayContent = Blocked loading mixed display content "%1$S"
BlockMixedActiveContent = Blocked loading mixed active content "%1$S"
Comment 1 Garrett Robinson [:grobinson] 2013-04-25 10:05:36 PDT
Created attachment 741919 [details] [diff] [review]
Patch 1

Who should review this?
Comment 2 Francesco Lodolo [:flod] (mostly out of office until Dec 19) 2013-04-25 10:21:07 PDT
> Who should review this?
Good question, not sure if you need a review considering it's just adding a comment.

I think that a single comment would be enough (at least it's what they do in other files, e.g. http://hg.mozilla.org/mozilla-central/file/690b5e0f6562/browser/locales/en-US/chrome/browser/browser.properties)

# LOCALIZATION NOTE (BlockMixedDisplayContent, BlockMixedActiveContent): 
# "%1$S" is the URI of the blocked mixed content resource
Comment 3 Garrett Robinson [:grobinson] 2013-04-25 14:31:30 PDT
Created attachment 742040 [details] [diff] [review]
Patch 2

Don't repeat the same comment for two consecutive localization strings.
Comment 4 Garrett Robinson [:grobinson] 2013-04-25 14:35:26 PDT
Created attachment 742047 [details] [diff] [review]
Patch 2.1

Don't repeat the same comment for two consecutive localization strings (posted wrong patch in last attachment accidentally).

Olli, I r?'ed you because you reviewed the patch where these messages were added in bug 837351. This patch just adds a comment for the benefit of the localizers.
Comment 5 Ryan VanderMeulen [:RyanVM] 2013-04-26 07:13:55 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf1a44d938bf
Comment 6 Ryan VanderMeulen [:RyanVM] 2013-04-26 18:41:57 PDT
https://hg.mozilla.org/mozilla-central/rev/bf1a44d938bf

Note You need to log in before you can comment on or make changes to this bug.