Closed Bug 865344 Opened 7 years ago Closed 7 years ago

Add a localization comment for BlockMixedDisplayContent and BlockMixedActiveContent

Categories

(Core :: Security, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: flod, Assigned: grobinson)

References

Details

Attachments

(1 file, 2 obsolete files)

As explained in bug 837351, a localization comment explaining what %1$S stands for would be useful for localizers.

BlockMixedDisplayContent = Blocked loading mixed display content "%1$S"
BlockMixedActiveContent = Blocked loading mixed active content "%1$S"
Assignee: nobody → grobinson
Attached patch Patch 1 (obsolete) — Splinter Review
Who should review this?
> Who should review this?
Good question, not sure if you need a review considering it's just adding a comment.

I think that a single comment would be enough (at least it's what they do in other files, e.g. http://hg.mozilla.org/mozilla-central/file/690b5e0f6562/browser/locales/en-US/chrome/browser/browser.properties)

# LOCALIZATION NOTE (BlockMixedDisplayContent, BlockMixedActiveContent): 
# "%1$S" is the URI of the blocked mixed content resource
Attached patch Patch 2 (obsolete) — Splinter Review
Don't repeat the same comment for two consecutive localization strings.
Attachment #741919 - Attachment is obsolete: true
Attachment #742040 - Flags: review?
Attached patch Patch 2.1Splinter Review
Don't repeat the same comment for two consecutive localization strings (posted wrong patch in last attachment accidentally).

Olli, I r?'ed you because you reviewed the patch where these messages were added in bug 837351. This patch just adds a comment for the benefit of the localizers.
Attachment #742040 - Attachment is obsolete: true
Attachment #742040 - Flags: review?
Attachment #742047 - Flags: review?(bugs)
Attachment #742047 - Flags: review?(bugs) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/bf1a44d938bf
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.