865344 - Add a localization comment for BlockMixedDisplayContent and BlockMixedActiveContent

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Francesco Lodolo [:flod]]

As explained in bug 837351, a localization comment explaining what %1$S stands for would be useful for localizers.

BlockMixedDisplayContent = Blocked loading mixed display content "%1$S"
BlockMixedActiveContent = Blocked loading mixed active content "%1$S"

Comment 1

[Garrett Robinson [:grobinson]]

Attachment: Patch 1

Who should review this?

Comment 2

[Francesco Lodolo [:flod]]

> Who should review this?
Good question, not sure if you need a review considering it's just adding a comment.

I think that a single comment would be enough (at least it's what they do in other files, e.g. http://hg.mozilla.org/mozilla-central/file/690b5e0f6562/browser/locales/en-US/chrome/browser/browser.properties)

# LOCALIZATION NOTE (BlockMixedDisplayContent, BlockMixedActiveContent): 
# "%1$S" is the URI of the blocked mixed content resource

Comment 3

[Garrett Robinson [:grobinson]]

Attachment: Patch 2

Don't repeat the same comment for two consecutive localization strings.

Comment 4

[Garrett Robinson [:grobinson]]

Attachment: Patch 2.1

Don't repeat the same comment for two consecutive localization strings (posted wrong patch in last attachment accidentally).

Olli, I r?'ed you because you reviewed the patch where these messages were added in bug 837351. This patch just adds a comment for the benefit of the localizers.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bf1a44d938bf

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bf1a44d938bf