865377 - Give EventTarget a chrome-only getter that returns the relevant global

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Boris Zbarsky [:bzbarsky, bz on IRC]]

The goal is that given an EventTarget "t" you can do:

  t.dispatchEvent(new t.global.Event("something"));

in chrome code and create the Event with the right permissions that event listeners on the target can touch it.

Questions:

1)  What should the attribute return?  I'm tempted to say "Window" for now...
2)  What should it be named?

Comment 1

[Olli Pettay [:smaug]]

(1) Window
(2) ownerGlobal?

Comment 2

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Attachment: Give EventTarget a chrome-only getter that returns its global. idea is that you then do things like t.dispatchEvent(new t.ownerGlobal.Event("something")).

Comment 3

[Olli Pettay [:smaug]]

Comment on attachment 756097 [details] [diff] [review]
Give EventTarget a chrome-only getter that returns its global.   idea is that you then do things like t.dispatchEvent(new t.ownerGlobal.Event("something")).

Hmm, you're returning outer window for nodes and inner window for DETHs.

{ goes to its own line at the beginning of a method.

r- because we need to return always same kind of window, and would be
good to even document that in EventTarget.h

Comment 4

[Boris Zbarsky [:bzbarsky, bz on IRC]]

> Hmm, you're returning outer window for nodes and inner window for DETHs.

Doesn't matter for JS callers.  Are you worried about C++ callers?

Do you just always want to see the outer window here?

Comment 5

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Attachment: Give EventTarget a chrome-only getter that returns its global. idea is that you then do things like t.dispatchEvent(new t.ownerGlobal.Event("something")).

Comment 6

[Olli Pettay [:smaug]]

Comment on attachment 756158 [details] [diff] [review]
Give EventTarget a chrome-only getter that returns its global.   idea is that you then do things like t.dispatchEvent(new t.ownerGlobal.Event("something")).


>+nsIDOMWindow*
>+nsINode::GetOwnerGlobal()
>+{
>+  return nsPIDOMWindow::GetOuterFromCurrentInner(OwnerDoc()->GetInnerWindow());
>+}
oh, crap. I realized we want to support data documents too.
So this should use GetScriptHandlingObject().
bool dummy;
return nsPIDOMWindow::GetOuterFromCurrentInner(static_cast<nsGlobalWindow*>OwnerDoc()->GetScriptHandlingObject(dummy));
Something like that.


>+  virtual nsIDOMWindow* GetOwnerGlobal() MOZ_OVERRIDE {
{ goes to the next line
>+'WindowProxy': [
>+{
>+    'nativeType': 'nsIDOMWindow',
>+    'concrete': False
>+},
>+{
>+    'workers': True
>+}],
workers True needs some explanation.

Comment 7

[Boris Zbarsky [:bzbarsky, bz on IRC]]

> So this should use GetScriptHandlingObject().

Good catch, done.

Addressed the other two as well.

https://hg.mozilla.org/integration/mozilla-inbound/rev/a6de622f9574

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a6de622f9574