865456 - Crashing and restoring is resuming with a blank session (apptabs are still restored)

Status: RESOLVED INVALID

(Firefox :: Session Restore, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

I've had three crashes today and in all three instances all of my tabs were lost when I resumed (with the exception of the apptabs).

Some of these crashes are happening while scrolling and others happen when I switch tabs.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

These are the crash IDs for me:

bp-2b288bb2-db13-4e19-ace9-282c62130424
bp-af9a67c8-6cce-4e0c-ad32-50a792130424
bp-b55fa7c2-bbe0-4644-81d4-4ea732130423
bp-bd6bfb60-d096-43e8-9cf6-e9fff2130423

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Regardless of what is the crash-of-the-day, we shouldn't be losing session state like this.

If the app tabs can be restored, then some of the session state isn't being corrupted. What's happening to the rest of the session?

Comment 4

[Joe Drew (not getting mail)]

I don't know if this happened in 22, but it's certainly happening in 23.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Tim, can you take a look at this?

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

I could reproduce this on my trunk build as well and then realized that 'browser.sessionstore.resume_from_crash' was set to 'false'. Jared and Joe had the pref flipped as well. I interestingly couldn't find any code that sets it to false, the default value is true.

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

We figured out this pref gets set to false when using the mozregression tool.

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

(In reply to Tim Taubert [:ttaubert] from comment #7)
> We figured out this pref gets set to false when using the mozregression tool.

So is there anything to do here other than know this pref gets set by the tool?  Should the toolmakers be asked to reset the pref at the end of a run?

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Yeah, the tool should be fixed. Jared filed https://github.com/mozilla/mozregression/issues/66 though, so I don't see a need to track this here.