865484 - [keyboard] refactor dictionary data structure and search algorithm for auto-correct

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[David Flanagan [:djf]]

I've filed various bugs about the data structure and algorithm we use for predictions and auto-correction, but ended up fixing them with a single patch. So I'm filing this new bug so I'll have a single place to attach my patch.

Comment 1

[David Flanagan [:djf]]

Attachment: link to patch on github

Comment 2

[David Flanagan [:djf]]

Setting all the bugs this patch fixes as dependents

Comment 3

[Gregor Wagner [:gwagner]]

Comment on attachment 741558 [details]
link to patch on github

r=me with followup/fix for comma issue.

Comment 4

[David Flanagan [:djf]]

Landed on master: 
https://github.com/mozilla-b2g/gaia/commit/413482d038560cb4065d4866013c15c64730bdfe

Comment 5

[Wayne Chang [:wchang]]

Triage - Adding clee for this bug fixes bugs 860538 860541 860624 862430, which are all pending product decision to include auto-correct in v1.1.

Comment 6

[Mike Lee [:mlee]]

Tracking since this change is wanted by UX but quality of fix needs to be assessed before decision to uplift. See below:

On 5/7/13 12:03 AM, Christopher Lee wrote:

    Thanks Francis. 

    Sounds like you and Josh are going to review the latest patches from David tomorrow and provide an assessment on the quality.  

    I'm also going to get a build tomorrow and evaluate the latest changes and we can collectively make a call on if it's ready for uplift.

Comment 7

[Tony Chung [:tchung]]

Please add a testcase for this bug to moztrap for 1.1 testsuite.  If yes, mark this in-moztrap+ when completed.  If not, mark this in-moztrap-.

Comment 8

[David Flanagan [:djf]]

Uplifted to v1-train in bug 873934

Comment 9

[:CSchmoeckel]

Issue does not appear to be testable. This bug is for a collection of dictionary specific issues that were fixed. Test Cases do not appear to be necessary here.