[keyboard] refactor dictionary data structure and search algorithm for auto-correct

RESOLVED FIXED
(NeedInfo from)

Status

Firefox OS
Gaia::Keyboard
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: djf, Assigned: djf, NeedInfo)

Tracking

unspecified
x86
Mac OS X
Dependency tree / graph
Bug Flags:
in-moztrap -

Firefox Tracking Flags

(blocking-b2g:-, b2g18+ fixed)

Details

(Whiteboard: c=auto-correct)

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
I've filed various bugs about the data structure and algorithm we use for predictions and auto-correction, but ended up fixing them with a single patch. So I'm filing this new bug so I'll have a single place to attach my patch.
(Assignee)

Updated

5 years ago
Assignee: nobody → dflanagan
(Assignee)

Comment 1

5 years ago
Created attachment 741558 [details]
link to patch on github
Attachment #741558 - Flags: review?(anygregor)
(Assignee)

Comment 2

5 years ago
Setting all the bugs this patch fixes as dependents
Blocks: 797170
Depends on: 860624, 859508, 860538, 860541, 862430
(Assignee)

Updated

5 years ago
Attachment #741558 - Flags: review?(mozilla)
Comment on attachment 741558 [details]
link to patch on github

r=me with followup/fix for comma issue.
Attachment #741558 - Flags: review?(anygregor) → review+
Attachment #741558 - Flags: review?(mozilla) → review+
(Assignee)

Comment 4

5 years ago
Landed on master: 
https://github.com/mozilla-b2g/gaia/commit/413482d038560cb4065d4866013c15c64730bdfe
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
blocking-b2g: --- → leo?

Updated

5 years ago
Whiteboard: c=auto-correct
Triage - Adding clee for this bug fixes bugs 860538 860541 860624 862430, which are all pending product decision to include auto-correct in v1.1.

Updated

5 years ago
Flags: needinfo?(clee)

Comment 6

5 years ago
Tracking since this change is wanted by UX but quality of fix needs to be assessed before decision to uplift. See below:

On 5/7/13 12:03 AM, Christopher Lee wrote:

    Thanks Francis. 

    Sounds like you and Josh are going to review the latest patches from David tomorrow and provide an assessment on the quality.  

    I'm also going to get a build tomorrow and evaluate the latest changes and we can collectively make a call on if it's ready for uplift.
tracking-b2g18: --- → +

Updated

5 years ago
blocking-b2g: leo? → -

Updated

5 years ago
Blocks: 873934
Blocks: 867175

Comment 7

5 years ago
Please add a testcase for this bug to moztrap for 1.1 testsuite.  If yes, mark this in-moztrap+ when completed.  If not, mark this in-moztrap-.
Flags: in-moztrap?(cschmoeckel)
(Assignee)

Comment 8

5 years ago
Uplifted to v1-train in bug 873934
status-b2g18: --- → fixed

Comment 9

5 years ago
Issue does not appear to be testable. This bug is for a collection of dictionary specific issues that were fixed. Test Cases do not appear to be necessary here.
Flags: in-moztrap?(cschmoeckel) → in-moztrap-
You need to log in before you can comment on or make changes to this bug.