Closed
Bug 865509
Opened 12 years ago
Closed 12 years ago
JS debugger: UnsolicitedPauses in dbg-client.jsm should mention 'exception'
Categories
(DevTools :: Debugger, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 23
People
(Reporter: jimb, Assigned: jimb)
References
Details
Attachments
(1 file)
|
557 bytes,
patch
|
dcamp
:
review+
|
Details | Diff | Splinter Review |
When resuming with pauseOnExceptions set, the server may send a "paused" packet whose 'why' type is 'exception'. DebuggerClient.prototype.onPacket ought to recognize that as not being a response, but since 'exception' does not appear in the UnsolicitedPauses table, it treats it as a response.
As a result, the call to this.activeThread.detach in DebuggerClient.prototype.close can end up calling its callback function, detachTab, as soon as client receives the "paused" packet, because ThreadClient.prototype.detach treats the "paused" packet as a response. This may result in the transport being closed before the eventual "detached" packet has been delivered. Delivering packets to closed transports causes an error.
Attachment #741603 -
Flags: review?(dcamp)
|
||
Updated•12 years ago
|
Attachment #741603 -
Flags: review?(dcamp) → review+
|
Assignee | |
Comment 1•12 years ago
|
||
Status: NEW → ASSIGNED
Flags: in-testsuite+
Target Milestone: --- → Firefox 23
|
||
Comment 2•12 years ago
|
||
Assignee: nobody → jimb
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•