D3E KeyboardEvent.key values of IME related keys should be considered with keyboard layout locale

RESOLVED FIXED in mozilla25

Status

()

Core
Widget: Win32
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

(Depends on: 1 bug, {dev-doc-complete, inputmethod, intl})

Trunk
mozilla25
x86_64
Windows 8
dev-doc-complete, inputmethod, intl
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

On Windows, some virtual keycode values for IME related keys are shared between Japanese keyboard layout and Korean keyboard layout. We should use different key values for them by checking the keyboard layout locale.

Additionally, some keys for IME cause OEM virtual keycodes. They should also be mapped with keyboard layout locale.
Status: NEW → ASSIGNED
Depends on: 773526
Created attachment 768199 [details] [diff] [review]
Refer current keyboard layout locale at mapping from native keycode to D3E key name index on Windows

See comment 0 for the detail.
Attachment #768199 - Flags: review?(jmathies)
Attachment #768199 - Flags: review?(bugs)

Comment 2

4 years ago
Comment on attachment 768199 [details] [diff] [review]
Refer current keyboard layout locale at mapping from native keycode to D3E key name index on Windows

I assume this makes us behave like IE does.
Attachment #768199 - Flags: review?(bugs) → review+
> I assume this makes us behave like IE does.

IE 10 doesn't support the special keys of Korean keyboard. They are mapped to "Unindentified".

Additionally, "FullWidth", "HalfWidth", "Alphanumeric", "Hiragana" and "Katakana" of Japanese keyboard layout are mapped to "Unidentified".

Finally, IE 10 maps "KanaMode" to "Attn" because the virtual keycode VK_ATTN is used for the Kana Mode/Roman Character mode key. I believe that this is a bug of IE because the key isn't actual "attention" key.

So, our implementation will advance one more step than IE 10.

Updated

4 years ago
Attachment #768199 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5fddca814e0

Comment 5

4 years ago
https://hg.mozilla.org/mozilla-central/rev/b5fddca814e0
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent#Key_names_and_Char_values
Keywords: dev-doc-complete
You need to log in before you can comment on or make changes to this bug.