865604 - Copy in purchase confirmation email is not localized

Status: VERIFIED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P1)

Description

[krupa raj[:krupa]]

Attachment: screenshot

Country tested from-Spain

steps to reproduce:
1. Change the language to Espanol on the phone
2. Make a purchase on marketplace-stage
3. Once the purchase is complete, check the confirmation email

expected behavior:
Copy in the confirmation email is in Spanish

observed behavior:
Copy in the confirmation email is in English

Comment 1

[Wraithan (Chris McDonald) [:wraithan]]

Per :robhudson this text was changed last week and likely is just untranslated so far. Searched locale/ after updating and don't see the string or file mentioned in there.

Assigning to clouserw to pull/update strings from zamboni.

Comment 2

[Wil Clouser [:clouserw]]

I extracted last night

Comment 3

[Wraithan (Chris McDonald) [:wraithan]]

https://github.com/mozilla/zamboni/commit/d1985cdaca410845342d4178161f3a73feaa4037

We don't extract from .txt files. Changed the template to .html and :clouserw said he'll extract the strings. Will need to get new translations in before this starts showing up localized.

Comment 6

[Andrew Williamson [:eviljeff]]

from https://bugzilla.mozilla.org/show_bug.cgi?id=891938#c2
"I'm still getting receipts in English:

From: Firefox Marketplace <[e-mail]>
Date: 2013/7/24
Subject: Receipt for Bag of Dice
To: [e-mail]


Thank you for purchasing from the Firefox Marketplace.

App name: Bag of Dice
App developer: curtis3

Order date: July 24, 2013
Order number: dd376e1b80aa2361c0e6b2c1c76d5ae8

For support please visit: https://github.com/classam/bag_of_dice_support/issues
Your purchase history: https://marketplace.firefox.com/purchases
Marketplace Terms of Service: https://marketplace.firefox.com/terms-of-use"

Comment 7

[Wraithan (Chris McDonald) [:wraithan]]

https://github.com/mozilla/zamboni/commit/0f7baf1f8d84668f06c42a17c6c0285c12f51624

We were activating the locale in the wrong place.

Comment 8

[krupa raj[:krupa]]

At https://marketplace.allizom.org/admin/mail i only see emails in English even though I was in Espanol.

Comment 9

[Matt Basta [:basta]]

Fireplace sends the user's language as a URL parameter to the webpay URLs after a purchase is made. Not sure if that would be helpful here.

Comment 10

[Wraithan (Chris McDonald) [:wraithan]]

https://github.com/mozilla/zamboni/commit/e700fdf44249f92b94262b5683de27d37f3085fe

If you had changed your locale a few times you could get it to work (which I happened to ahve done when I was testing this) so I was mistaken that is was fixed. I also had a test that worked so I was very confident... this should be the final little bit needed to make this actually work all the time.

basta: it is a background task, so grabbing it off of the user's saved language is good enough (assuming the middleware doesn't get in the way).

Comment 11

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/0c688bd
https://github.com/mozilla/zamboni/commit/c60431a

Comment 12

[krupa raj[:krupa]]

I verified this bug last week. Purchased an app in Spanish and got the email receipt fully localized in Espanol.

Comment 13

[krupa raj[:krupa]]

Attachment: email receipt.png