865615 - Remove Accessible::DOMNode

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement, P5)

Description

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Requested in bug 864286 comment 3.

Comment 1

[alexander :surkov (:asurkov)]

iirc we wanted to replace it on raw pointer version (I guess via nsINode::AsDOMNode())

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

I think there's only two or so uses, so it's probably easier to deal in the callers.

Comment 3

[Marco Zehe (:MarcoZ)]

Will we still have the ability to reference the original DOM node from the accessible? I believe some of the JSAT folder uses, or new patches plan to use, this to gain access to the original node coming from the accessible object.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

GetNode().

Comment 5

[alexander :surkov (:asurkov)]

jsat is xpcom based, this bug is about internal method

Comment 6

[alexander :surkov (:asurkov)]

(In reply to :Ms2ger from comment #2)
> I think there's only two or so uses, so it's probably easier to deal in the
> callers.

I don't mind

Comment 7

[Videet Singhai]

Can anyone please explain this bug. I would like to work on it.

Comment 8

[alexander :surkov (:asurkov)]

(In reply to Videet Singhai from comment #7)
> Can anyone please explain this bug. I would like to work on it.

technically, you should replace Accessible:DOMNode() instances on more appropriate calls like GetContent or GetNode().

https://searchfox.org/mozilla-central/source/accessible/generic/Accessible.h#169

Comment 9

[dora.tokio]

Is nobody assigned to this bug yet?

Comment 10

[Mostafa Ibrahem]

(In reply to dora.tokio from comment #9)
> Is nobody assigned to this bug yet?

yup,nobady mean that no body is assigned

Comment 11

[alexander :surkov (:asurkov)]

yep, feel free to claim it if you are keen to work on it

Comment 12

[dora.tokio]

Thanks, I'd like to work on it.

Accessible::DOMNode() is called only twice, in a similar situation. So, I rewrite XULTabAccessible.cpp as follows, is this correct?

Before:
>  nsCOMPtr<nsIDOMNode> domNode(DOMNode());
>  nsCOMPtr<nsIDOMNode> tabpanelNode;
>  tabsElm->GetRelatedElement(domNode, getter_AddRefs(tabpanelNode));

After:
>  nsCOMPtr<nsIDOMNode> domNode(do_QueryInterface(GetNode()));
>  nsCOMPtr<nsIDOMNode> tabpanelNode;
>  tabsElm->GetRelatedElement(domNode, getter_AddRefs(tabpanelNode));

Comment 13

[alexander :surkov (:asurkov)]

yep, sounds good

Comment 14

[dora.tokio]

Attachment: Remove Accessible::DOMNode

replace Accessible::DOMNode with Accessible::GetNode version

MozReview-Commit-ID: 9p74ISHnWzF

Comment 15

[dora.tokio]

I'm sorry but some extra file was included in the patch. I'll try it again.

Comment 16

[dora.tokio]

Attachment: Remove Accessible::DOMNode

replace Accessible::DOMNode with Accessible::GetNode version

Comment 17

[dora.tokio]

Oh, I'm so sorry again, an extra character 'S' was included.

Comment 18

[dora.tokio]

Attachment: Remove Accessible::DOMNode

replace Accessible::DOMNode with Accessible::GetNode version

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5a9d5bca98b
Remove Accessible::DOMNode. r=surkov

Comment 20

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/a5a9d5bca98b