865655 - SDK needs to be build using MOZ_FOLD_LIBS define

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[Denis]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20130418 Firefox/22.0
Build ID: 20130418004017

Steps to reproduce:

I need XULRunner SDK to be compatible with appropriate Firefox version.


Actual results:

Due to nspr4.dll and others are missing I cannot work with Firefox 22 using SDK from XULRunner 22.


Expected results:

I believe XULRunner and Firefox must be both built using MOZ_FOLD_LIBS define

Comment 1

[Mike Hommey [:glandium]]

Attachment: Enable MOZ_FOLD_LIBS in xulrunner for the SDK to match Firefox

Comment 2

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/09ebbdf6ff52

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/09ebbdf6ff52

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 748764 [details] [diff] [review]
Enable MOZ_FOLD_LIBS in xulrunner for the SDK to match Firefox

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 648407
User impact if declined: SDK doesn't match Firefox, which prevents e.g. building binary components that can be properly loaded by Firefox.
Risk to taking this patch (and alternatives if risky): NPOTB for Firefox. Essentially, this takes a snippet from Firefox's confvars.sh and uses it when building xulrunner (which is what gets us the SDK)
String or IDL/UUID changes made by this patch: None

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 748764 [details] [diff] [review]
Enable MOZ_FOLD_LIBS in xulrunner for the SDK to match Firefox

NPOTB

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c783c6426e5b
https://hg.mozilla.org/releases/mozilla-beta/rev/df1e13ac3e62