8657 - Fix numerous compiler warnings in libimg

Status: RESOLVED WONTFIX

(Core :: Graphics: ImageLib, defect, P3)

Description

[David Gardiner]

Files in modules\libimg\

pngcom\png_png.cpp(30) warning C4005: 'ERROR' : macro redefinition

src\ilclient.cpp(373) : warning C4018: '!=' : signed/unsigned mismatch
src\ilclient.cpp(374) : warning C4018: '!=' : signed/unsigned mismatch
src\ilclient.cpp(438) : warning C4101: 'result' : unreferenced local variable

src\il_util.cpp(103) : warning C4244: '=' : conversion from 'unsigned long' to
'unsigned char', possible loss of data
src\il_util.cpp(104) : warning C4244: '=' : conversion from 'unsigned long' to
'unsigned char', possible loss of data
src\il_util.cpp(105) : warning C4244: '=' : conversion from 'unsigned long' to
'unsigned char', possible loss of data
src\il_util.cpp(109) : warning C4244: '=' : conversion from 'unsigned long' to
'unsigned char', possible loss of data
src\il_util.cpp(116) : warning C4244: '=' : conversion from 'unsigned long' to
'unsigned char', possible loss of data
src\il_util.cpp(118) : warning C4244: '=' : conversion from 'unsigned long' to
'unsigned char', possible loss of data
src\il_util.cpp(120) : warning C4244: '=' : conversion from 'unsigned long' to
'unsigned char', possible loss of data
src\il_util.cpp(306) : warning C4244: '=' : conversion from 'long' to 'unsigned
char', possible loss of data

src\scale.cpp(208) : warning C4244: '=' : conversion from 'unsigned long' to
'unsigned short', possible loss of data
src\scale.cpp(698) : warning C4018: '>=' : signed/unsigned mismatch
src\scale.cpp(724) : warning C4018: '!=' : signed/unsigned mismatch
src\scale.cpp(730) : warning C4018: '>=' : signed/unsigned mismatch
src\scale.cpp(751) : warning C4018: '!=' : signed/unsigned mismatch
src\scale.cpp(757) : warning C4018: '>=' : signed/unsigned mismatch

Patches use casts to fix compiler warnings.

Comment 1

[David Gardiner]

Attachment: Fix redefine of ERROR

Comment 2

[David Gardiner]

Attachment: Fix warnings

Comment 3

[David Gardiner]

Attachment: Patch to fix warnings

Comment 4

[David Gardiner]

Attachment: Patch to fix warnings

Comment 5

[David Gardiner]

Attachment: Patch to fix warnings in ilclient.cpp

Comment 6

[David Gardiner]

Attachment: Patch to fix warnings in scale.cpp

Comment 7

[David Gardiner]

Attachment: Patch to fix if_struct.h

Comment 8

[David Gardiner]

Attachment: Patch to il_utilp.h to help fix warnings in other files

Comment 9

[Eli Goldberg]

pnunn/neeti, are there any problems with the submitted patches, or why is this
being resolved as LATER?

Thanks!

Comment 10

[pnunn]

Most of these probably have been fixed, but I don't
have time to verify.
-p

Comment 11

[Eli Goldberg]

[e-mail], I'm going to resolve this bug as VERIFIED/LATER.

Although I know it's an imposition and do apologize, if you'd like to determine
which of these compiler warnings are still relevant and confirm that the patches
are still relevant, please feel free to.

Comment 12

[Christopher Hoess (gone)]

LATER is deprecated.

Comment 13

[Christopher Hoess (gone)]

WONTFIX. libimg is dead.