warning in nsGUIEventIPC.h: potential use of uninitialized variable

RESOLVED FIXED in mozilla23

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

unspecified
mozilla23
x86_64
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 741888 [details] [diff] [review]
patch, eliminate uninitialized-variable warning in nsGUIEventIPC.h

The patch in bug 842927 (pt 1) introduced a compile warning in nsGUIEventIPC.h, in the ParamTraits<nsKeyEvent>::Read() method.

If the first ReadParam() call ever returns false, the subsequent ones will not be executed, and so keyNameIndex will still be uninitialized when it is used to set the mKeyNameIndex field.

Suggested fix is to simply avoid using keyNameIndex unless the ReadParam() calls all succeeded.
Attachment #741888 - Flags: review?(bugs)

Updated

6 years ago
Attachment #741888 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/6a62fb95a40b
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.