Closed Bug 865715 Opened 6 years ago Closed 6 years ago

warning in nsGUIEventIPC.h: potential use of uninitialized variable

Categories

(Core :: DOM: Events, defect)

x86_64
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: jfkthame, Assigned: jfkthame)

References

Details

Attachments

(1 file)

The patch in bug 842927 (pt 1) introduced a compile warning in nsGUIEventIPC.h, in the ParamTraits<nsKeyEvent>::Read() method.

If the first ReadParam() call ever returns false, the subsequent ones will not be executed, and so keyNameIndex will still be uninitialized when it is used to set the mKeyNameIndex field.

Suggested fix is to simply avoid using keyNameIndex unless the ReadParam() calls all succeeded.
Attachment #741888 - Flags: review?(bugs)
Attachment #741888 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/6a62fb95a40b
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.