865746 - [HiDPI] Downloads panel icons are disproportionately large

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Greg Edwards]

Attachment: Downloads panel at 96dpi

Just like Bug 818935, only with the new expanding downloads panel

Comment 1

[Greg Edwards]

Attachment: Downloads panel at 192dpi

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: [win-hidpi] explicitly set size of download item icons

This is the Windows version of the OS X patch in bug 815512 pt 2. On a hidpi configuration, the system may give us an icon that is larger (in pixel dimensions) than the CSS px size we want; we need to explicitly set the desired size in our CSS so that the extra pixels result in a sharp icon at the proper size, instead of a blurry icon at a larger CSS-px size.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Hey Jonathan,

I know that bug 854555 took care of OSX, but are strangely sized icons in the Library also a problem for HiDPI displays in Windows?

If so, we should maybe update that here as well.

I don't have a HiDPI system to test with, so I can't say for certain if the Library will be a problem, but I suspect it might.

-Mike

Comment 4

[Jonathan Kew [:jfkthame]]

AFAICS, the Library looks OK on Windows/HiDPI - Greg, do you see a problem there, or only in the Downloads panel?

Comment 5

[Jonathan Kew [:jfkthame]]

Actually, the reason downloads in the Library list are OK on Windows is that we already fixed that in bug 818935.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Ah, gotcha, thanks.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 741947 [details] [diff] [review]
[win-hidpi] explicitly set size of download item icons

Yep, this looks like the right move. Thanks!

Comment 8

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/da9f02088406

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/da9f02088406

Comment 10

[Jonathan Kew [:jfkthame]]

Comment on attachment 741947 [details] [diff] [review]
[win-hidpi] explicitly set size of download item icons

[Approval Request Comment]
Bug caused by (feature/regressing bug #): windows hi-dpi support

User impact if declined: minor cosmetic glitch (icon too large)

Testing completed (on m-c, etc.): currently in Nightly and Aurora

Risk to taking this patch (and alternatives if risky): minimal, just a styling fix

String or IDL/UUID changes made by this patch: none

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2f1499631ace

Comment 12

[Tracy Walker [:tracy]]

mass remove verifyme requests greater than 4 months old