865766 - GCC init list ordering build warning for MessageLoop in message_loop.cc

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Daniel Holbert [:dholbert]]

Build warning:
{
In file included from /mozilla-central/ipc/chromium/src/base/message_loop.cc:5:0:
/mozilla-central/ipc/chromium/src/base/message_loop.h: In constructor 'MessageLoop::MessageLoop(MessageLoop::Type)':
/mozilla-central/ipc/chromium/src/base/message_loop.h:424:7: warning: 'MessageLoop::next_sequence_num_' will be initialized after [-Wreorder]
   int next_sequence_num_;
       ^
In file included from /mozilla-central/ipc/chromium/src/base/message_loop.cc:5:0:
/mozilla-central/ipc/chromium/src/base/message_loop.h:380:11: warning:   'PRInt32 MessageLoop::id_' [-Wreorder]
   PRInt32 id_;
           ^
/mozilla-central/ipc/chromium/src/base/message_loop.cc:91:1: warning:   when initialized here [-Wreorder]
 MessageLoop::MessageLoop(Type type)
 ^
}

The "id_" member-var was added in this cset for bug 857152:
  http://hg.mozilla.org/mozilla-central/rev/c97f19dc7f7f
but it was put into the wrong place in the init list.

Patch coming up.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

id_ is declared immediately after type_, as shown here:

> 379   Type type_;
> 380   PRInt32 id_;
http://mxr.mozilla.org/mozilla-central/source/ipc/chromium/src/base/message_loop.h#379

This patch reorders the init list to initialize it after type_, to match.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/06927647efd7

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/06927647efd7