865778 - stop making assumptions about mozconfig names in release sanity

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[[e-mail] (:bhearsum)]

bug 853071 is going to change the in-tree mozconfigs a bit. After it's done we'll have mozconfigs that are used for releases that end in "beta". Release sanity makes some assumptions about mozconfig naming that will become invalid when this is done:
https://github.com/mozilla/build-tools/blob/master/lib/python/release/sanity.py#L83
https://github.com/mozilla/build-tools/blob/master/lib/python/release/sanity.py#L89

We should either fix this to strip the last part of the path regardless of what it is, or be explicit about which mozconfig we should compare against by putting them in the release config. Maybe something like:
releaseConfig['mozconfigs'] = {
  'linux': {
    'nightly': '...',
    'release': '...'
  }
}

Comment 1

[[e-mail] (:bhearsum)]

We need this bug to support bug 853071 in release automation. 23.0b1 will be the first release with that code.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: get rid of assumptions

Turns out that we can look up the nightly mozconfigs in the branchConfig rather than duplicating that information to the release ones. I tested this locally by rerunning release sanity for 22.0b3.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 757474 [details] [diff] [review]
get rid of assumptions

I'm on the hook for the beta this week, so this is a good time to get the first production run!