865885 - Add a more descriptive name for webworkers

Status: RESOLVED WORKSFORME

(Core :: Gecko Profiler, defect)

Comment 1

[Benoit Girard (:BenWa)]

Attachment: patch

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 751544 [details] [diff] [review]
patch

Review of attachment 751544 [details] [diff] [review]:
-----------------------------------------------------------------

r=me as long as the reuse case is alright.

::: dom/workers/RuntimeService.cpp
@@ +522,5 @@
>      }
>  
>      JSRuntime* rt = JS_GetRuntime(cx);
>  
> +    nsCString escapedDomain(workerPrivate->Domain());

Nit: nsAutoCString

@@ +533,5 @@
> +    workerName = NS_LITERAL_CSTRING("WebWorker (") +
> +                 escapedDomain + NS_LITERAL_CSTRING(") (") +
> +                 escapedURL + NS_LITERAL_CSTRING(")");
> +
> +    profiler_register_thread(workerName.BeginReading());

What happens if you call this more than once? Will it just replace the old name? Threads are reused for different workers in some cases.

Comment 3

[Benoit Girard (:BenWa)]

(In reply to ben turner [:bent] (gone until July 22) from comment #2)
> @@ +533,5 @@
> > +    workerName = NS_LITERAL_CSTRING("WebWorker (") +
> > +                 escapedDomain + NS_LITERAL_CSTRING(") (") +
> > +                 escapedURL + NS_LITERAL_CSTRING(")");
> > +
> > +    profiler_register_thread(workerName.BeginReading());
> 
> What happens if you call this more than once? Will it just replace the old
> name? Threads are reused for different workers in some cases.

As long as they run through profiler_unregister_thread then first it should be fine.

Comment 4

[Benoit Girard (:BenWa)]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=8f9912ae2555

Comment 5

[Benoit Girard (:BenWa)]

This got fixed in another bug. A similar patch has landed.