865931 - PJS: Add test for wild comparisons

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Niko Matsakis [:nmatsakis]]

I was trying to get this test to pass:

```
load(libdir + "parallelarray-helpers.js");

// Test that we are able to compare numbers even if the typesets are
// not "clean" because we have previously added strings and numbers.
// Also test that we distinguish between bools/numbers etc for strict
// equality but not loose equality.

function theTest() {
  var ints = range(0, 1024);
  var doubles = ints.map(v => v + 0.1);
  var bools = ints.map(v => (v % 2) == 0);
  var strings = ints.map(v => String(v));

  function looselyCompareToDoubles(e, i) {
    return doubles[i] == e;
  }
  print("doubles");
  compareAgainstArray(doubles, "map", looselyCompareToDoubles)
  print("bools");
  compareAgainstArray(bools, "map", looselyCompareToDoubles)
  print("strings");
  compareAgainstArray(strings, "map", looselyCompareToDoubles)
  print("ints");
  compareAgainstArray(ints, "map", looselyCompareToDoubles)

  function strictlyCompareToDoubles(e, i) {
    return doubles[i] === e;
  }
  print("doubles");
  compareAgainstArray(doubles, "map", strictlyCompareToDoubles)
  print("bools");
  compareAgainstArray(bools, "map", strictlyCompareToDoubles)
  print("strings");
  compareAgainstArray(strings, "map", strictlyCompareToDoubles)
  print("ints");
  compareAgainstArray(ints, "map", strictlyCompareToDoubles)
}

if (getBuildConfiguration().parallelJS)
  theTest();
```

and I ran into problems. The first of which was that ConvertArrayToDouble is considered unsafe for par exec. I have a fix for that I will attach in a second. The other was limitations of our testing infrastructure. I have also addressed those in the work on OMTC.

Comment 1

[Niko Matsakis [:nmatsakis]]

Attachment: Allow ConvertElementsToDoubles in par mode

Comment 2

[Niko Matsakis [:nmatsakis]]

Added a dependency on bug 862892 because the testing infrastructure I built there would allow this test to pass, I believe, given attachment 742114 [details] [diff] [review]

Comment 3

[Niko Matsakis [:nmatsakis]]

Attachment: Fix misc bugs in the parallel comparison routines and add a test case.

I am obsoleting attachment 742114 [details] [diff] [review] since the problem with ConvertElementsToDoubles is solved better in bug 854400

Comment 4

[Niko Matsakis [:nmatsakis]]

Try run for this patch (along with bug 854400) looks green: https://tbpl.mozilla.org/?tree=Try&rev=ec8d7228222b

Comment 5

[Shu-yu Guo [:shu]]

Comment on attachment 747232 [details] [diff] [review]
Fix misc bugs in the parallel comparison routines and add a test case.

Review of attachment 747232 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, another SAFE_OP.

Comment 6

[Niko Matsakis [:nmatsakis]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/262cf57a8aa7

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/262cf57a8aa7