Closed
Bug 865958
Opened 11 years ago
Closed 11 years ago
text in a <clipPath> does not reflow when changed
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
People
(Reporter: heycam, Assigned: longsonr)
Details
Attachments
(2 files)
475 bytes,
image/svg+xml
|
Details | |
757 bytes,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
See the attached test. This is broken with both the old and new text frames.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #742784 -
Flags: review?(cam)
Reporter | ||
Comment 2•11 years ago
|
||
Comment on attachment 742784 [details] [diff] [review] fix old text frames I assume it's not problematic that this will update the glyph metrics if both NS_STATE_SVG_NONDISPLAY_CHILD and NS_FRAME_FIRST_REFLOW are set.
Attachment #742784 -
Flags: review?(cam) → review+
Assignee | ||
Comment 3•11 years ago
|
||
If NS_STATE_SVG_NONDISPLAY_CHILD is set then NS_FRAME_FIRST_REFLOW is never cleared as the frames never get an InitialUpdate call which is what clears it.
Assignee | ||
Comment 4•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=9d99a4fedebe
Reporter | ||
Comment 5•11 years ago
|
||
(In reply to Robert Longson from comment #3) > If NS_STATE_SVG_NONDISPLAY_CHILD is set then NS_FRAME_FIRST_REFLOW is never > cleared as the frames never get an InitialUpdate call which is what clears > it. Makes sense, though it must be something like that.
Assignee: nobody → longsonr
Status: NEW → ASSIGNED
Reporter | ||
Comment 6•11 years ago
|
||
*thought
Comment 7•11 years ago
|
||
Comment on attachment 742784 [details] [diff] [review] fix old text frames >+ if ((GetStateBits() & (NS_STATE_SVG_NONDISPLAY_CHILD | NS_FRAME_FIRST_REFLOW)) != >+ NS_FRAME_FIRST_REFLOW) { Can you maybe write that as the following? if (!(GetStateBits() & NS_FRAME_FIRST_REFLOW) || (GetStateBits() & NS_STATE_SVG_NONDISPLAY_CHILD)) { I think that makes it easier to grasp what this logic is doing. (And since GetStateBits() is inline there's negligible extra overhead in doing it that way.)
Assignee | ||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9af815f4a9f
Whiteboard: [leave open]
Assignee | ||
Comment 9•11 years ago
|
||
Marking [leave open] assuming a new text frame solution is required.
Assignee: longsonr → nobody
Assignee | ||
Updated•11 years ago
|
Whiteboard: [leave open]
Assignee | ||
Comment 11•11 years ago
|
||
Cameron, are you planning to do anything for new text frames here? If not we should mark this as fixed.
Reporter | ||
Comment 12•11 years ago
|
||
This is working again in the new text world.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → longsonr
You need to log in
before you can comment on or make changes to this bug.
Description
•