B2G RIL: support detect voice radio technology changes

NEW
Unassigned

Status

Firefox OS
RIL
5 years ago
a year ago

People

(Reporter: edgar, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 4 obsolete attachments)

(Reporter)

Description

5 years ago
RIL v7 introduces a new unsol command, RIL_UNSOL_VOICE_RADIO_TECH_CHANGED, to indicate the voice technology has changed. We should support this.
(Reporter)

Updated

5 years ago
Assignee: nobody → echen
(Reporter)

Updated

5 years ago
Summary: B2G RIL: support detect radio technology changes → B2G RIL: support detect voice radio technology changes
(Reporter)

Comment 1

5 years ago
Created attachment 754750 [details] [diff] [review]
Handle RIL_UNSOL_VOICE_RADIO_TECH_CHANGED, v1
(Reporter)

Comment 2

4 years ago
Created attachment 773854 [details] [diff] [review]
Part 1: Handle RIL_UNSOL_VOICE_RADIO_TECH_CHANGED, v2
Attachment #754750 - Attachment is obsolete: true
(Reporter)

Comment 3

4 years ago
Created attachment 773890 [details] [diff] [review]
P
(Reporter)

Comment 4

4 years ago
Created attachment 773892 [details] [diff] [review]
Part 2: Xpcshell tests for RIL_UNSOL_VOICE_RADIO_TECH_CHANGED, v1
Attachment #773890 - Attachment is obsolete: true
(Reporter)

Comment 5

4 years ago
Created attachment 773893 [details] [diff] [review]
Part 2: Xpcshell tests for RIL_UNSOL_VOICE_RADIO_TECH_CHANGED, v1

Upload correct patch
Attachment #773892 - Attachment is obsolete: true
(Reporter)

Comment 6

4 years ago
Created attachment 773894 [details] [diff] [review]
Part 2: Xpcshell tests for RIL_UNSOL_VOICE_RADIO_TECH_CHANGED, v1

Wrong again, I think it's time to go home :(
Attachment #773893 - Attachment is obsolete: true
(Reporter)

Updated

4 years ago
Attachment #773854 - Flags: review?(vyang)
(Reporter)

Updated

4 years ago
Attachment #773894 - Flags: review?(vyang)
Comment on attachment 773854 [details] [diff] [review]
Part 1: Handle RIL_UNSOL_VOICE_RADIO_TECH_CHANGED, v2

Review of attachment 773854 [details] [diff] [review]:
-----------------------------------------------------------------

Maybe we should hold down for a while and develop a solid process for radio tech transition first.

::: dom/system/gonk/ril_consts.js
@@ -196,3 @@
>  
>  // Akami/Maguro specific parcels.
> -this.UNSOLICITED_VOICE_RADIO_TECH_CHANGED = 1034;

Please remove all Akami/Maguro specific types.  They're never implemented and probably never will.

::: dom/system/gonk/ril_worker.js
@@ +5590,5 @@
> +  // This unsolicited response will be sent when the technology of a multi-tech
> +  // modem is changed, ex. switch between gsm and cdma. Currently the only known
> +  // multi-tech modem is emulator (qemu can support both gsm and cdma).
> +  // TODO: We may need to reset some data when switching between gsm and cdma
> +  //       mode, like IMEI, ESN ... etc.

And that's what we should worry about.  Before it becomes a complete solution and is full tested, I don't think we need a half-made part now :(
Attachment #773854 - Flags: review?(vyang) → review-
Comment on attachment 773894 [details] [diff] [review]
Part 2: Xpcshell tests for RIL_UNSOL_VOICE_RADIO_TECH_CHANGED, v1

xpcshell test case doesn't really help to ensure a well solid process in handling radio tech transition.
Attachment #773894 - Flags: review?(vyang)
Component: DOM: Device Interfaces → RIL
Product: Core → Boot2Gecko
Version: Trunk → unspecified
(Reporter)

Updated

3 years ago
See Also: → bug 1092108
(Reporter)

Comment 9

a year ago
Unassigning myself as I am no longer working on this.
Assignee: echen → nobody
You need to log in before you can comment on or make changes to this bug.