Closed
Bug 866059
Opened 12 years ago
Closed 12 years ago
Don't implicitly convert to already_AddRefed in Codegen.py
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla23
People
(Reporter: ayg, Assigned: ayg)
References
Details
Attachments
(1 file)
|
1.59 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
I didn't know how to use the nsRefPtr/nsCOMPtr thing because I didn't know how to get the type, or what a safe variable name would be.
Attachment #742305 -
Flags: review?(Ms2ger)
Flags: in-testsuite-
|
||
Comment 1•12 years ago
|
||
Comment on attachment 742305 [details] [diff] [review]
Patch
Review of attachment 742305 [details] [diff] [review]:
-----------------------------------------------------------------
I'd rather bz looked at this.
Attachment #742305 -
Flags: review?(Ms2ger) → review?(bzbarsky)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 742305 [details] [diff] [review]
Patch
Yeah, this makes sense. r=me
Attachment #742305 -
Flags: review?(bzbarsky) → review+
|
Assignee | |
Comment 3•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/10ff3d7fbf6d
Green try (failures are from other patches): https://tbpl.mozilla.org/?tree=Try&rev=8cbdbebfff18
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•