Closed Bug 866059 Opened 6 years ago Closed 6 years ago

Don't implicitly convert to already_AddRefed in Codegen.py

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: ayg, Assigned: ayg)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
I didn't know how to use the nsRefPtr/nsCOMPtr thing because I didn't know how to get the type, or what a safe variable name would be.
Attachment #742305 - Flags: review?(Ms2ger)
Flags: in-testsuite-
Comment on attachment 742305 [details] [diff] [review]
Patch

Review of attachment 742305 [details] [diff] [review]:
-----------------------------------------------------------------

I'd rather bz looked at this.
Attachment #742305 - Flags: review?(Ms2ger) → review?(bzbarsky)
Comment on attachment 742305 [details] [diff] [review]
Patch

Yeah, this makes sense.  r=me
Attachment #742305 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/10ff3d7fbf6d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.