866259 - vector images need the unlocked draw notification too

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Timothy Nikkel (:tnikkel)]

Attachment: patch

Currently we use nsIDocument::Add/RemoveImage to track/untrack images that are visible or close to visible. But Add/RemoveImage also calls Increment/DecrementAnimationConsumers on the image (in addition to Lock/Unlock). This means our tracking is also responsible for handling images that should be animated (but don't care about locks). So we need to call our unlocked draw notification for vector images too, so they can animate.

This may change when we start tracking both when an image is in an active tab and when it is visible its current tab

Comment 1

[Timothy Nikkel (:tnikkel)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/be2a35cd5739

Comment 2

[Timothy Nikkel (:tnikkel)]

Comment on attachment 742530 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 689623
User impact if declined: dynamically added img's that contain svg won't animate
Testing completed (on m-c, etc.): just landed on inbound now
Risk to taking this patch (and alternatives if risky): this is a relatively safe patch, I think the risk of not taking it is higher than the risk of taking it
String or IDL/UUID changes made by this patch: none

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/be2a35cd5739

Comment 4

[Timothy Nikkel (:tnikkel)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5ff080963a6a

Comment 5

[Biraj Karmakar [:biraj]]

Is there any testing is needed?

Comment 6

[Timothy Nikkel (:tnikkel)]

If you wanted to verify that this is fixed you could dynamically add an img element that contains an svg file with animation (contains an animated gif or has svg animation, etc).