Closed Bug 866264 Opened 13 years ago Closed 13 years ago

Intermittent devtools/styleeditor/test/browser_styleeditor_new.js | new editor shows 1 rule after modification - Got 2, expected 1

Categories

(DevTools :: Style Editor, defect)

Product:
DevTools
Component:
Style Editor
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 23

People

(Reporter: RyanVM, Assigned: harth)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

fix event ordering
4.02 KB, patch
dcamp
: review+
Details | Diff | Splinter Review
Likely a regression from bug 816967. https://tbpl.mozilla.org/php/getParsedLog.php?id=22295178&tree=Fx-Team Rev3 Fedora 12x64 fx-team opt test mochitest-browser-chrome on 2013-04-26 12:31:05 PDT for push 8911b764dc1e slave: talos-r3-fed64-048 12:51:14 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_new.js | new editor has unsaved flag 12:51:14 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_new.js | Console message: [JavaScript Warning: "XUL box for h3 element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/orion.js" line: 7896}] 12:51:14 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_new.js | Console message: [JavaScript Warning: "XUL box for h3 element contained an inline #text child, forcing all its children to be wrapped in a block." {file: "chrome://browser/content/styleeditor.xul" line: 0}] 12:51:15 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_new.js | new editor shows 1 rule after modification - Got 2, expected 1 12:51:15 INFO - Stack trace: 12:51:15 INFO - JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 527 12:51:15 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/styleeditor/test/browser_styleeditor_new.js :: <TOP_LEVEL> :: line 56 12:51:15 INFO - JS frame :: resource:///modules/devtools/EventEmitter.jsm :: <TOP_LEVEL> :: line 56 12:51:15 INFO - JS frame :: resource:///modules/devtools/EventEmitter.jsm :: EventEmitter_emit :: line 100 12:51:15 INFO - JS frame :: resource:///modules/devtools/StyleEditorDebuggee.jsm :: <TOP_LEVEL> :: line 307 12:51:15 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: EV_notify :: line 148 12:51:15 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: <TOP_LEVEL> :: line 625 12:51:15 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 120 12:51:15 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 45 12:51:15 INFO - JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 155 12:51:15 INFO - JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DC_onPacket :: line 633 12:51:15 INFO - JS frame :: chrome://global/content/devtools/dbg-transport.js :: <TOP_LEVEL> :: line 224 12:51:15 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
Was firing a rule-count-changed event right after inserting the style editor's transition rule (so shows 2 rules instead of 1), now it fires before inserting the extra rule. Also fixed test to be more robust. Passes a try server run.
Assignee: nobody → fayearthur
Attachment #742687 - Flags: review?(dcamp)
Attachment #742687 - Flags: review?(dcamp) → review+
https://hg.mozilla.org/mozilla-central/rev/59ce4fbce0c2
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 23
(In reply to TinderboxPushlog Robot from comment #30) > edmorley > https://tbpl.mozilla.org/php/getParsedLog.php?id=22455809&tree=Mozilla- > Inbound > Rev3 Fedora 12x64 mozilla-inbound opt test mochitest-browser-chrome on > 2013-05-01 03:42:02 > slave: talos-r3-fed64-052 > > 04:01:51 WARNING - TEST-UNEXPECTED-FAIL | > chrome://mochitests/content/browser/browser/devtools/styleeditor/test/ > browser_styleeditor_new.js | new editor shows 1 rule after modification - > Got 2, expected 1 (Fix not yet on inbound)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: