If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

remote debugging protocol: number packets when dumping

RESOLVED FIXED in Firefox 23

Status

()

Firefox
Developer Tools: Debugger
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jimb, Assigned: jimb)

Tracking

Trunk
Firefox 23
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 742549 [details] [diff] [review]
Remote debugging protocol: show sequence numbers with packets.

It makes packet logs a lot easier to read if you associate numbers with packets, and print when the packet is sent and received. For the simple tests, it's not interesting, but for the more involved tests, it's extremely helpful to be able to see when something was sent, and when it was actually received.
(Assignee)

Updated

5 years ago
Attachment #742549 - Flags: review?(past)
(Assignee)

Comment 1

5 years ago
Created attachment 742579 [details] [diff] [review]
Remote debugging protocol: show sequence numbers with packets.

Revised. Works better when the count is shared between the two paired LocalDebuggerTransport instances...
Assignee: nobody → jimb
Attachment #742549 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #742549 - Flags: review?(past)
Attachment #742579 - Flags: review?(past)
Comment on attachment 742579 [details] [diff] [review]
Remote debugging protocol: show sequence numbers with packets.

Review of attachment 742579 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/debugger/dbg-transport.js
@@ +262,4 @@
>     * endpoint.
>     */
>    send: function LDT_send(aPacket) {
> +    let serial = this.serial.count++;

Wouldn't it make sense to move this inside the if(wantLogging) branch?
Attachment #742579 - Flags: review?(past) → review+
(Assignee)

Comment 3

5 years ago
(In reply to Panos Astithas [:past] from comment #2)
> Comment on attachment 742579 [details] [diff] [review]
> Remote debugging protocol: show sequence numbers with packets.
> 
> Review of attachment 742579 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: toolkit/devtools/debugger/dbg-transport.js
> @@ +262,4 @@
> >     * endpoint.
> >     */
> >    send: function LDT_send(aPacket) {
> > +    let serial = this.serial.count++;
> 
> Wouldn't it make sense to move this inside the if(wantLogging) branch?

I thought about that. But if something turns wantLogging on or off in the midst of a session, we could have packets sent before the switch being delivered after the switch, and it seemed like it would be more comprehensible to have them all numbered.
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/e245f0728bc9
Flags: in-testsuite-
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: --- → Firefox 23

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/e245f0728bc9
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.