866358 - sdp_main.c:1466:5: warning: implicit declaration of function ‘vcmOnSdpParseError’ [-Wimplicit-function-declaration]

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Daniel Holbert [:dholbert]]

GCC build warning (using GCC 4.8):
{
media/webrtc/signaling/src/sipcc/core/sdp/sdp_main.c: In function ‘sdp_parse_error’:
media/webrtc/signaling/src/sipcc/core/sdp/sdp_main.c:1466:5: warning: implicit declaration of function ‘vcmOnSdpParseError’ [-Wimplicit-function-declaration]
}

This file is invoking vcmOnSdpParseError without ever #including the correct header for that function's declaration.

Just needs an #include "vcm.h".

(Looks like this function-call was introduced in https://hg.mozilla.org/mozilla-central/rev/c9d9b906b4e0 for bug 805533 -- adding dependency on that bug.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix: add #include

Comment 2

[Daniel Holbert [:dholbert]]

(this fixes the build warning for me, locally)

Comment 3

[Daniel Holbert [:dholbert]]

[Cargo-culting whiteboard status from other webrtc build-warning bug 866317.]

Comment 4

[Ethan Hugg [:ehugg]]

Comment on attachment 742650 [details] [diff] [review]
fix: add #include

Review of attachment 742650 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 5

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/84235d548347

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/84235d548347