Closed
Bug 866471
Opened 12 years ago
Closed 12 years ago
Change assert for self-hosted functions into debug-only macro
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: mozillabugs, Assigned: sankha)
References
Details
(Whiteboard: [js:t])
Attachments
(1 file)
|
1.68 KB,
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
Assertions in self-hosted JavaScript code are currently expressed using the assert function in Utilities.js. This means that their condition is evaluated in all builds, while in general assertions in Mozilla code are evaluated only in debug builds.
assert should be changed into a macro that evaluates its condition only in debug builds.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #771574 -
Flags: review?(mozillabugs)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 771574 [details] [diff] [review]
patch v1
Review of attachment 771574 [details] [diff] [review]:
-----------------------------------------------------------------
Stealing review. Very nice, thanks!
Attachment #771574 -
Flags: review?(mozillabugs) → review+
|
|
||
Comment 3•12 years ago
|
||
Assignee: general → sankha93
Status: NEW → ASSIGNED
Whiteboard: [js:t]
|
|
||
Comment 4•12 years ago
|
||
Follow-up to fix bug-that-the-reviewer-should-have-caught.
https://hg.mozilla.org/integration/mozilla-inbound/rev/49f214cec133
|
||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9ddffab2da7b
https://hg.mozilla.org/mozilla-central/rev/49f214cec133
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•