86651 - contrib/cvs-update.sh sets sticky dates

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect, P3)

Description

[Jacob Steenhagen]

Whenever bugzilla is updated via the cvs-update.sh script it sets stick dates on
all bugzilla files.  This has the downside that individual files can't be
updated (unless the -A tag is used) and changes can't be commited.

What the patch I'm about to upload does is changes it so '-A' gets used when
updating (to remove any sticky dates/tags).  It still logs the command w/the -D
so that a change can backed out of the running install.

Comment 1

[Jacob Steenhagen]

Attachment: patch

Comment 2

[Jacob Steenhagen]

-> New Bugzilla Product

Comment 3

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 4

[Bradley Baetz (:bbaetz)]

Comment on attachment 39126 [details] [diff] [review]
patch

This will make the logged date different to the real date if a checkin occurs
between the echo and the update -A. I guess thats unlikely to be a problem in
practice.

r=bbaetz if you think we're happy with that limitation

Comment 5

[Jouni Heikniemi]

Comment on attachment 39126 [details] [diff] [review]
patch

r=jouni

Comment 6

[Bradley Baetz (:bbaetz)]

myk - bmo uses this script, don't they?

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Yes, and I can't think of anything this patch breaks, so although it worries me,
I think it's probably ok.

Comment 8

[Jacob Steenhagen]

Checking in cvs-update.sh; written
/cvsroot/mozilla/webtools/bugzilla/contrib/cvs-update.sh,v  <--  cvs-update.sh
new revision: 1.2; previous revision: 1.1
done