866567 - mask layers sometimes broken with OMTC?

Status: VERIFIED FIXED

(Core :: Graphics: Layers, defect)

Description

[Nick Cameron [:nrc]]

Bug 862236 wallpapered over an issue where mask layers were causing an assertion. I could not reproduce at the time. If we ever notice dodgy rounded corners under OMTC we could undo the patch there and try and track down the cause.

Comment 1

[Nick Cameron [:nrc]]

Attachment: test case

I have no idea if this is due to the bug I mentioned in the above comment, but this case is definitely broken. I think this might be a more recent regression because it is part of my mask layers test suite which I run every now and then, but it does trip the added warning.

Comment 2

[Nick Cameron [:nrc]]

Go on then, I suppose I'll try and fix this.

Comment 3

[Nick Cameron [:nrc]]

Attachment: fix

Comment 4

[Nick Cameron [:nrc]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/630b073105d0

Comment 5

[Nick Cameron [:nrc]]

Comment on attachment 762378 [details] [diff] [review]
fix

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 867474
User impact if declined: incorrect rendering of some elements with border-radius
Testing completed (on m-c, etc.): I'll let it marinate for a couple of days on m-c
Risk to taking this patch (and alternatives if risky): low - tiny amount of code that was present before 867474 and is present on main thread layers backends.
String or IDL/UUID changes made by this patch: none

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/630b073105d0

Comment 7

[bhavana bajaj [:bajaj]]

Comment on attachment 762378 [details] [diff] [review]
fix

Low risk Fx23 regression.Approving for uplift.

Comment 8

[Nick Cameron [:nrc]]

aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/44fa2c31bf71

Comment 9

[Bogdan Maris, Desktop Test Engineering]

Mozilla/5.0 (X11; Linux i686; rv:23.0) Gecko/20100101 Firefox/23.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:23.0) Gecko/20100101 Firefox/23.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20100101 Firefox/23.0

I don`t know what exactly would be the correct behavior but I loaded the test case on 23 RC (buildID: 20130730113002) and latest Nightly (buildID: 20130731030203) and after moving the mouse pointer on the right side of the browser the rectangle moves slowly on the right but does not change form, it does change color. 
In Chrome, Opera, Safari the rectangle moves to the right changes the color and the rounded corners change into straight corners.

What is the correct behavior here?

Comment 10

[Nick Cameron [:nrc]]

(In reply to Bogdan Maris [QA] [:bogdan_maris] from comment #9)
> Mozilla/5.0 (X11; Linux i686; rv:23.0) Gecko/20100101 Firefox/23.0
> Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:23.0) Gecko/20100101
> Firefox/23.0
> Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20100101 Firefox/23.0
> 
> I don`t know what exactly would be the correct behavior but I loaded the
> test case on 23 RC (buildID: 20130730113002) and latest Nightly (buildID:
> 20130731030203) and after moving the mouse pointer on the right side of the
> browser the rectangle moves slowly on the right but does not change form, it
> does change color. 
> In Chrome, Opera, Safari the rectangle moves to the right changes the color
> and the rounded corners change into straight corners.
> 
> What is the correct behavior here?

Move the cursor over the rectangle, and keep it there as it moves. It should move to the right and turn a paler colour.

Comment 11

[Bogdan Maris, Desktop Test Engineering]

Yes it does that so if that is the correct behavior then this is verified as fixed.

Comment 12

[Bogdan Maris, Desktop Test Engineering]

Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Firefox/24.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:24.0) Gecko/20100101 Firefox/24.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Firefox/24.0

Verified as fixed on Firefox 24 beta 4 (buildID: 20130819170952) and latest Nightly (buildID: 20130820030206).