Closed Bug 866588 Opened 7 years ago Closed 7 years ago
"Assertion failure: Get
First In Flow() != a Prev In Flow" with LRE, pre-wrap, :first-line
Assertion failure: GetFirstInFlow() != aPrevInFlow, at layout/generic/nsInlineFrame.cpp:964 This assertion was added in bug 861643.
nsBidiPresUtils::ResolveParagraph makes the continuation non-fluid. Simon, is this a bug?
Fwiw, this fixes it but maybe we should check IsBidiSplittable(parent) instead like we do in similar code a few lines down. http://hg.mozilla.org/mozilla-central/annotate/05533d50f2f7/layout/base/nsBidiPresUtils.cpp#l859
I seem to recall that you had a patch recently in this block but that it was rejected / backed out for some reason?
Do you mean bug 722137, which got backed out in bug 818454, then reapplied in bug 826163, and the code that you're now touching got added at the same time. It's probably worth testing with the testcase I just attached to bug 818454, attachment 743037 [details].
Thanks, that's the bugs I was looking for. I've checked the tests in those bugs. https://tbpl.mozilla.org/?tree=Try&rev=a273a2bf514b (other tests were green in a previous run)
Attachment #743297 - Flags: review?(smontagu) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.