866588 - "Assertion failure: GetFirstInFlow() != aPrevInFlow" with LRE, pre-wrap, :first-line

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: testcase (asserts fatally when loaded)

Assertion failure: GetFirstInFlow() != aPrevInFlow, at layout/generic/nsInlineFrame.cpp:964

This assertion was added in bug 861643.

Comment 1

[Jesse Ruderman]

Attachment: stack (gdb)

Comment 2

[Mats Palmgren (inactive)]

Attachment: frame dump

nsBidiPresUtils::ResolveParagraph makes the continuation non-fluid.

Simon, is this a bug?

Comment 3

[Mats Palmgren (inactive)]

Attachment: wallpaper

Fwiw, this fixes it but maybe we should check IsBidiSplittable(parent)
instead like we do in similar code a few lines down.
http://hg.mozilla.org/mozilla-central/annotate/05533d50f2f7/layout/base/nsBidiPresUtils.cpp#l859

Comment 4

[Mats Palmgren (inactive)]

Attachment: wip

https://tbpl.mozilla.org/?tree=Try&rev=1fdcd4ee53f8

Comment 5

[Mats Palmgren (inactive)]

I seem to recall that you had a patch recently in this block but that it was
rejected / backed out for some reason?

Comment 6

[Simon Montagu :smontagu]

Do you mean bug 722137, which got backed out in bug 818454, then reapplied in bug 826163, and the code that you're now touching got added at the same time.

It's probably worth testing with the testcase I just attached to bug 818454, attachment 743037 [details].

Comment 7

[Mats Palmgren (inactive)]

Attachment: fix+test

Thanks, that's the bugs I was looking for.  I've checked the tests
in those bugs.

https://tbpl.mozilla.org/?tree=Try&rev=a273a2bf514b
(other tests were green in a previous run)

Comment 8

[Mats Palmgren (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1b5ab2426f16

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1b5ab2426f16