866632 - [gcli] |cookie list| on about page shows 'no cookies found for host', should use 'No cookies found for this page'

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

Nightly and Aurora, Windows XP SP3

Opening the gcli while having about:home (or about:blank) open and calling |cookie list| shows 'No cookies found for host'. If look at http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/devtools/gclicommands.properties#774 , you can see that this fails gracefully in English because the host value is at end of the string and blank, but this will likely cause trouble for other localizations. cookieListOutNonePage doesn't seem to be used despite the description.

# LOCALIZATION NOTE (cookieListOutNonePage) The output of the 'cookie list'
# command uses this string for pages like 'about:blank' which can't contain
# cookies
cookieListOutNonePage=No cookies found for this page

# LOCALIZATION NOTE (cookieListOutNoneHost) The output of the 'cookie list'
# command uses this string when there are no cookies on a given web page
cookieListOutNoneHost=No cookies found for host %1$S

Comment 1

[Joe Walker [:jwalker] (needinfo me or ping on irc)]

The cookieListOutNonePage string is used here http://mxr.mozilla.org/mozilla-central/source/browser/devtools/commandline/BuiltinCommands.jsm#980

The "cookie list" command allows the user to specify a host (the host of the current page is taken as the default) so it's wrong to assume the current page. We'll have to do something special in the case where the host is null.

Comment 2

[Joe Walker [:jwalker] (needinfo me or ping on irc)]

Attachment: v1

Comment 3

[Joe Walker [:jwalker] (needinfo me or ping on irc)]

Green on try: https://tbpl.mozilla.org/?tree=Try&rev=7ac21da57bbe

Comment 4

[Joe Walker [:jwalker] (needinfo me or ping on irc)]

https://tbpl.mozilla.org/?tree=Fx-Team&rev=9ae9cc383d0f
https://hg.mozilla.org/integration/fx-team/rev/e55e6114c0e4

Comment 5

[Joe Walker [:jwalker] (needinfo me or ping on irc)]

https://hg.mozilla.org/mozilla-central/rev/e55e6114c0e4