866636 - AddonUpdateChecker bypasses it cache, but doesn't inhibit writing to it

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Seems AddonUpdateChecker.jsm bypasses the cache when requesting the update manifest (using LOAD_BYPASS_CACHE), but doesn't inhibit writing to it. It should!

It sets LOAD_BYPASS_CACHE here:
http://hg.mozilla.org/mozilla-central/file/1c0e964bd620/toolkit/mozapps/extensions/AddonUpdateChecker.jsm#l414

It should also set INHIBIT_CACHING, like what is done in bug 866564 in LightweightThemeManager.jsm:
https://bugzilla.mozilla.org/page.cgi?id=splinter.html&bug=866564&attachment=742892

Comment 1

[Ritesh]

I want to work on this bug. Do I need to just set the INHIBIT_CACHING flag (one line) or something else?

(In reply to Blair McBride [:Unfocused] (Back from the dead. Mostly.) from comment #0)
> Seems AddonUpdateChecker.jsm bypasses the cache when requesting the update
> manifest (using LOAD_BYPASS_CACHE), but doesn't inhibit writing to it. It
> should!
> 
> It sets LOAD_BYPASS_CACHE here:
> http://hg.mozilla.org/mozilla-central/file/1c0e964bd620/toolkit/mozapps/
> extensions/AddonUpdateChecker.jsm#l414
> 
> It should also set INHIBIT_CACHING, like what is done in bug 866564 in
> LightweightThemeManager.jsm:
> https://bugzilla.mozilla.org/page.cgi?id=splinter.
> html&bug=866564&attachment=742892

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Yes, you just need to set that flag - a one line fix, like what the patch in bug 866564 is doing.

Comment 3

[Ritesh]

Attachment: Just added flag for INHIBIT_CACHING

Comment 4

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 744048 [details] [diff] [review]
Just added flag for INHIBIT_CACHING

Review of attachment 744048 [details] [diff] [review]:
-----------------------------------------------------------------

Great - thanks Ritesh :)

One small thing that I'll fix up for you: Be careful with spaces versus tabs. We use 2 spaces to indent lines in Mozilla code, not tabs (I personally prefer tabs, but its best to be consistent with the rest of the code).

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Landed on the fx-team branch, which will get merged into mozilla-central within a day or two:
https://hg.mozilla.org/integration/fx-team/rev/e8c1bde62025

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/e8c1bde62025