866641 - Port registerCleanupFunction() method from mochitest browser-chrome to mochitest plain

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The registerCleanupFunction method for Mochitest browser is very helpful if specific tasks have to be run before the test is finished. Mochitest plain is missing this feature and makes it hard to do the right cleanup logic for heavy asynchronous tests. It would be fantastic if we can get the method and related code ported over to mochitest plain.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: add registerCleanupFunction method to mochitest-plain

This does the trick.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 743185 [details] [diff] [review]
add registerCleanupFunction method to mochitest-plain

Review of attachment 743185 [details] [diff] [review]:
-----------------------------------------------------------------

I would like to see a test case that adds 2 cleanup functions.  The rest looks pretty safe.

Comment 3

[(not currently active) Ted Mielczarek]

I made the sanity test set two prefs and use two separate cleanup functions to unset them, and check both of them in test_sanity_cleanup2:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e13bb42d2872

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e13bb42d2872