866645 - B2G CDMA: Get the mcc/mnc of CDMA RUIM

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Edgar Chen [:edgar]]

Ril parse iccInfo.mcc and iccInfo.mnc when reading EF_AD, but in CDMA mode, ril does not handle EF_AD. So the mcc/mnc of iccInfo are 'undefined'. We may need to find a way to get mcc/mnc of CDMA RUIM.

Comment 1

[Patrick Wang (Chih-Kai Wang) (:kk1fff)]

MCC/MNC is from IMSI's first 5 digits (C.S0005 2.3.1), we should able to get IMSI from EF_IMSI_M.

Comment 2

[Edgar Chen [:edgar]]

(In reply to Patrick Wang [:kk1fff] from comment #1)
> MCC/MNC is from IMSI's first 5 digits (C.S0005 2.3.1), we should able to get
> IMSI from EF_IMSI_M.

Actually, MNC can be 2 digits or 3 digits [1]. In gsm mode, we check the 4th byte of EF_AD to decide the mnc is 2 digits or 3 digits. It seems RUIM has EF_AD as well, but I didn't see mnc information mentioned in spec. (C.S0023-D session 3.4.33)

[1] http://en.wikipedia.org/wiki/Mobile_Network_Code

Comment 3

[Edgar Chen [:edgar]]

AOSP has implemented a MCC table which contains all mcc and corresponding mnc length [1]. If mnc length information isn't showed in EF_AD, AOSP will use this table to get mnc length [2].

[1] https://android.googlesource.com/platform/frameworks/opt/telephony/+/master/src/java/com/android/internal/telephony/MccTable.java#319
[2] https://android.googlesource.com/platform/frameworks/opt/telephony/+/master/src/java/com/android/internal/telephony/uicc/RuimRecords.java#215

Comment 4

[Edgar Chen [:edgar]]

In bug 880369, we add a MCC table for the case that AD dose not contain the length of MNC in some SIM card. I think we could re-use this table for CDMA. Thanks

Comment 5

[Edgar Chen [:edgar]]

Attachment: Part 1: Get the mcc/mnc of CDMA RUIM, v1

1). Move the code of mcc/mnc parsing into a utility function, parseMccMncFromImsi.
2). For CDMA, there is no mncLength information in EF_AD, so we needn't to read EF_AD, we could parse mcc/mnc directly right after we got IMSI.

Comment 6

[Edgar Chen [:edgar]]

Attachment: Part 2: Xpcshell tests for the utility function of mcc/mnc parsing, v1

Comment 7

[Edgar Chen [:edgar]]

Attachment: Part 2: Xpcshell tests for the utility function of mcc/mnc parsing, v2

Comment 8

[Edgar Chen [:edgar]]

try server: https://tbpl.mozilla.org/?tree=Try&rev=1d59255c2795

Comment 9

[Edgar Chen [:edgar]]

try server: https://tbpl.mozilla.org/?tree=Try&rev=7a1d303f7dbb

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/projects/birch/rev/433ebb4c854b
https://hg.mozilla.org/projects/birch/rev/099014c88d3c

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/433ebb4c854b
https://hg.mozilla.org/mozilla-central/rev/099014c88d3c