866720 - Notes app is not working when device is offline

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[isabelrios]

Ikura device
Build id: 20130426165700
Git commit 2013-04-26 083157

PROCEDURE
*Use the device without data or wifi connection.
1. Open Notes application

EXPECTED
The application can be used as usual

ACTUAL
Somtimes we see a white screen and the app is never open.
Some other times, there is a message warning user that Notes requires a network connection. 

This affects certification, adding dep and nominating it

Comment 1

[Jason Smith [:jsmith]]

This is because the partner customizations aren't including the appcache resources - we're referencing an appcache path that doesn't exist:

https://github.com/telefonicaid/firefoxos-gaia-latam/tree/master/external-apps/notes

https://github.com/telefonicaid/firefoxos-gaia-spain/tree/master/external-apps/notes

Technically this isn't the app developer's fault - it's a partner customization bug.

Yuren - Can you take a look?

Comment 2

[Daniel Coloma:dcoloma]

We need to fix this or otherwise we just need to remove this app

Comment 3

[Jason Smith [:jsmith]]

(In reply to Daniel Coloma:dcoloma from comment #2)
> We need to fix this or otherwise we just need to remove this app

We really should go the route of just fixing the customization here - this isn't the fault of the app developer at all. It's a MOZ + TEF issue here.

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

gaia-preload-app script doesn't support appcache. I'll inveistigate it since it will be a tef+ soon I think...

otherwise we can make note to a packaged app.

Comment 5

[Jason Smith [:jsmith]]

(In reply to Yuren Ju [:yurenju] from comment #4)
> gaia-preload-app script doesn't support appcache. I'll inveistigate it since
> it will be a tef+ soon I think...

Hmm...that means we should check what other apps are using the appcache_path then. In the spain and latam repositories above, I only see notes falling into this category.

> 
> otherwise we can make note to a packaged app.

We really should have gone this route from the beginning.

Comment 6

[Jason Smith [:jsmith]]

Karen - Is making notes a packaged app an option here for preinstalled apps? That would certainly make fixing this bug a whole lot easier.

Comment 7

[Lisa Brewster [:adora]]

A packaged version of Notes is in review.  It's also privileged, so the code review process will take extra time.

https://marketplace.firefox.com/reviewers/apps/review/notes-packaged

Comment 8

[Andrew Overholt [:overholt]]

(In reply to Yuren Ju [:yurenju] from comment #4)
> gaia-preload-app script doesn't support appcache. I'll inveistigate it since
> it will be a tef+ soon I think...

Feel free to un/re-assign if you're not the proper owner here, Yuren.  Thanks.

Comment 9

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Lisa, do you have schedule for packaged notes review? I thought this is the best way to solve this problem.

Comment 10

[Alex Keybl [:akeybl]]

Back to tef? given comment 7. An app-side workaround would be best at this point.

Comment 11

[Jason Smith [:jsmith]]

(In reply to Alex Keybl [:akeybl] from comment #10)
> Back to tef? given comment 7. An app-side workaround would be best at this
> point.

No. This requires a change in our partner customization repositories, so there will be a change on our side no matter what, even if it means we're moving from hosted to packaged.

Please put the bug back to tef+ - this is a firm requirement by TEF per the discussions I've been in.

Comment 12

[Jason Smith [:jsmith]]

The alternative fix to this problem if we remain hosted is to get the appcache resources as part of the partner customizations.

Comment 13

[Alex Keybl [:akeybl]]

OK, we'll make this NPOTB in that case since we'll either package the app or remove it entirely at this point (neither of which happen in the main B2G repos).

Comment 14

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Karen, do you have schedule for packaged notes review?

Comment 15

[Jason Smith [:jsmith]]

(In reply to Yuren Ju [:yurenju] from comment #14)
> Karen, do you have schedule for packaged notes review?

I asked Lisa about this today. She said Andrew was looking into this tomorrow.

Just to be clear - we need to make a call here if this app stays in the build or not. If any of the below scenarios happen, then the app needs to be pulled:

1. The app still fails to have offline support - either by not being packaged and failing to fix the appcache resource issue or not having the packaged app in time
2. The app isn't localized to target 1.01 locales

Comment 17

[Andrew Williamson [:eviljeff]]

(In reply to Jason Smith [:jsmith] from comment #15)
> (In reply to Yuren Ju [:yurenju] from comment #14)
> > Karen, do you have schedule for packaged notes review?
> 
> I asked Lisa about this today. She said Andrew was looking into this
> tomorrow.

I've looked at the code but the app isn't installing atm.  Possibly due to bug 841569.

Comment 18

[Andrew Williamson [:eviljeff]]

(In reply to Jason Smith [:jsmith] from comment #15)
> Just to be clear - we need to make a call here if this app stays in the
> build or not. If any of the below scenarios happen, then the app needs to be
> pulled:
...
> 2. The app isn't localized to target 1.01 locales

During my review I didn't see any evidence of localisation btw.

Comment 19

[Andrew Williamson [:eviljeff]]

(In reply to Andrew Williamson [:eviljeff] from comment #17)
> (In reply to Jason Smith [:jsmith] from comment #15)
> > (In reply to Yuren Ju [:yurenju] from comment #14)
> > > Karen, do you have schedule for packaged notes review?
> > 
> > I asked Lisa about this today. She said Andrew was looking into this
> > tomorrow.
> 
> I've looked at the code but the app isn't installing atm.  Possibly due to
> bug 841569.

Jason: is there a way can we verify that the app is failing to install due to bug 841569 and bump the priority on that bug if necessary?  I'm not the expert on signing errors.

Comment 20

[Jason Smith [:jsmith]]

(In reply to Andrew Williamson [:eviljeff] from comment #19)
> (In reply to Andrew Williamson [:eviljeff] from comment #17)
> > (In reply to Jason Smith [:jsmith] from comment #15)
> > > (In reply to Yuren Ju [:yurenju] from comment #14)
> > > > Karen, do you have schedule for packaged notes review?
> > > 
> > > I asked Lisa about this today. She said Andrew was looking into this
> > > tomorrow.
> > 
> > I've looked at the code but the app isn't installing atm.  Possibly due to
> > bug 841569.
> 
> Jason: is there a way can we verify that the app is failing to install due
> to bug 841569 and bump the priority on that bug if necessary?  I'm not the
> expert on signing errors.

If you are seeing INVALID_SIGNATURE in the logcat when you install a packaged app with reviewers certs preinstalled, then you are still getting the same error as what's shown in bug 841569.

Comment 21

[Andrew Williamson [:eviljeff]]

Lisa has confirmed that we are getting the INVALID SIGNITURE error so the packaged app approval is blocked on bug 841569.

Comment 22

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Daniel, should we remove notes app first and open a new bug for adding preload app back?

Comment 23

[Jason Smith [:jsmith]]

(In reply to Yuren Ju [:yurenju] from comment #22)
> Daniel, should we remove notes app first and open a new bug for adding
> preload app back?

I'm confused by this statement. Can you explain?

Comment 24

[[e-mail]]

Hi, I'm working on preload script to pre-cache all resources from appcache.


I found note app's appcache path is not valid because Github changed its static hosting page to github.io domain.


Currently we can not get appcache file from:

http://everythingme.github.com/ffos-notes/notes.appcache


But can get from the correct one:

http://everythingme.github.io/ffos-notes/notes.appcache


So the Note app may need to resubmit for a new domain or asking Firefox Marketplace to change it for them...


needinfo? Jason, do you know who is the right guy or right process to track that issue?

Comment 25

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Jason, Daniel said we need to fix it or otherwise remove it on comment 2 and I didn't get review schedule from app review team, so the simple way to solve this issue is remove this hosted app and file another bug to add preload app back.

but looks gasolin are implmenting appcahe support for gaia-preload-app, we also can use that way to sovle it.

Comment 26

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

sorry, s/preload/packaged/

Comment 27

[Jason Smith [:jsmith]]

(In reply to Fred Lin [:gasolin] from comment #24)
> needinfo? Jason, do you know who is the right guy or right process to track
> that issue?

Ah good catch. I'll redirect that request to Lisa to outreach to the developer here.

(In reply to Yuren Ju [:yurenju] from comment #25)
> Jason, Daniel said we need to fix it or otherwise remove it on comment 2 and
> I didn't get review schedule from app review team, so the simple way to
> solve this issue is remove this hosted app and file another bug to add
> preload app back.
> 
> but looks gasolin are implmenting appcahe support for gaia-preload-app, we
> also can use that way to sovle it.

Right, the appcache solution is definitely on the table. We need to do that anyways for other apps (Accuweather and Wikipedia are the others).

As for an update from the app review team, I've heard the notes packaged app is in review right now. Lisa would be a good person to ask about the status on that.

Comment 28

[Jason Smith [:jsmith]]

Let me direct your inquiry on Daniel to Karen btw. She has been tracking the work with notes and give input on what to do here.

Comment 29

[[e-mail]]

Ooh I find the simpler solution for customization: 

just change customer list path to 
http://everythingme.github.io/ffos-notes/manifest.webapp


But I think the Firefox Marketplace will still have the above(domain name changed) issue.

And refer to bug 870178 comment 16, Change 'appcache' name to 'manifest.appcache' helps.

Note app use 'notes.appcache' as appcache name, which can't be automatically cached in current implementation.

Comment 30

[Andrew Williamson [:eviljeff]]

(In reply to Jason Smith [:jsmith] from comment #27)
> As for an update from the app review team, I've heard the notes packaged app
> is in review right now. Lisa would be a good person to ask about the status
> on that.

I've just reviewed version 2.0.  Its still hitting bug 841569 so can't be installed.  I've suggested a possible workaround to the developer so we'll see how that turns out.

Comment 31

[Karen Ward [:kward]]

(In reply to Yuren Ju [:yurenju] from comment #14)
> Karen, do you have schedule for packaged notes review?

E.me submitted a packaged app for review on 5/12 but it did not pass.  e.me has committed to submitting an updated app on 5/16.  If the app passes Review then this bug can be closed.  (e.me will also submit an updated hosted app on 5/16 as a fall back).  This app will need to dropped from pre-installation if schedule cannot accommodate this timing.

Comment 32

[Jason Smith [:jsmith]]

(In reply to [e-mail] from comment #31)
> (In reply to Yuren Ju [:yurenju] from comment #14)
> > Karen, do you have schedule for packaged notes review?
> 
> E.me submitted a packaged app for review on 5/12 but it did not pass.  e.me
> has committed to submitting an updated app on 5/16.  If the app passes
> Review then this bug can be closed.  (e.me will also submit an updated
> hosted app on 5/16 as a fall back).  This app will need to dropped from
> pre-installation if schedule cannot accommodate this timing.

This bug can only be closed when we land the updates to customization repositories. It isn't enough to get the app review to pass to get this bug to be closed.

The three cases to close are:

1. We have a notes packaged app available, so we land the packaged app in the latam and spain customizations

2. We plan to stick with the hosted app, so we land the appcache resources in the latam and spain customizations

3. We plan to remove the app, so we land a change to pull the app from the customization repositories.

Comment 33

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Thank you Jason. there are some details below:

plan 1. blocking by app review

plan 2. we need to generate appcache for notes app and blocking by bug 871435

plan 3. that's the easy way...

Comment 34

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

I made a pull request for plan 2 here:

https://github.com/telefonicaid/firefoxos-gaia-spain/pull/16

so we are ready for plan 2 & 3. kevin, do you know who can decide this?

and thank you Gasolin & Fabrice for support appcache from preload script part & gecko part :)

Comment 35

[Kai-Chih Hu [:khu]]

I talked with dpv and we suggested to apply #2. Our understanding is, #1 and #2 might be similar to users. Since #2 looks easier than #1, we can choose #2. 

Thanks.

Comment 36

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: pull request: https://github.com/telefonicaid/firefoxos-gaia-spain/pull/16

Hi Fabrice, could you review the pull request? thanks!

Comment 37

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: pull request: https://github.com/telefonicaid/firefoxos-gaia-latam/pull/15

Comment 38

[David Palomino [:dpalomino]]

Many thanks Kevin, Yuren!

Comment 39

[Daniel Coloma:dcoloma]

I've merged the PRs in our repo, if a follow-up is required just let me know.

Comment 40

[Andrew Williamson [:eviljeff]]

(In reply to [e-mail] from comment #31)
> (In reply to Yuren Ju [:yurenju] from comment #14)
> > Karen, do you have schedule for packaged notes review?
> 
> E.me submitted a packaged app for review on 5/12 but it did not pass.  e.me
> has committed to submitting an updated app on 5/16.  If the app passes
> Review then this bug can be closed.  (e.me will also submit an updated
> hosted app on 5/16 as a fall back).  This app will need to dropped from
> pre-installation if schedule cannot accommodate this timing.

packaged app (v.2.0) approved btw.

Comment 41

[[:fabrice] Fabrice Desré]

Please test before asking for review. The appcache manifest is in  external-apps/notes/cache/notes.appcache but it should be in  external-apps/notes/cache/manifest.appcache

Comment 42

[Karen Ward [:kward]]

Packaged Notes app has now been approved by Apps Review team.  Please refer to Bugs for Homescreen builds for each OEM for details.  Manifest URL is: https://marketplace.firefox.com/app/fa85e65f-14ac-4736-89da-7fc27ac8862c/manifest.webapp

Comment 43

[Jason Smith [:jsmith]]

(In reply to Daniel Coloma:dcoloma from comment #39)
> I've merged the PRs in our repo, if a follow-up is required just let me know.

We shouldn't have merged this. As comment 41 states, this doesn't entirely work.

We now have the notes packaged app available anyways, so let's just get a followup PR to get that in there.

Comment 44

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Fabrice, I didn't rename notes.appcache because index.html in notes app use notes.appcache for cache, otherwise we need to use preload script to modify index.html and manifest.webapp. I'll open a follow-up bug to discuss it. 


anyway, finally we have packaged app! I'll create a new pull request for this.

Comment 45

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Attachment: pull request: https://github.com/telefonicaid/firefoxos-gaia-spain/pull/21

pull request for packaged app to spain repository.

tested on v1.0.1 branch with copy TEF_SPAIN/external-app/*  to GAIA_DIR/external-app/ and |GAIA_DISTRIBUTION_DIR=<TEF_SPAIN> MOZILLA_OFFICIAL=1 make production|

Comment 46

[Jason Smith [:jsmith]]

Comment on attachment 750841 [details]
pull request: https://github.com/telefonicaid/firefoxos-gaia-spain/pull/21

I don't see the actual notes packaged app zip file included in the commit. You also need to remove the cache files from the repository. Additionally, you need an update.webapp file to define the mini-manifest for the packaged app.

Comment 47

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

I lost files when rebase to master, sorry for that.

Comment 48

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 750841 [details]
pull request: https://github.com/telefonicaid/firefoxos-gaia-spain/pull/21

pull request updated

Comment 49

[Jason Smith [:jsmith]]

Comment on attachment 750841 [details]
pull request: https://github.com/telefonicaid/firefoxos-gaia-spain/pull/21

lgtm on my end.

The Paris team is awake and in office right now, so let redirect Fabrice's review to Julien, as he can do reviews on these patches as well.

Comment 50

[Daniel Coloma:dcoloma]

(In reply to Jason Smith [:jsmith] from comment #43)
> (In reply to Daniel Coloma:dcoloma from comment #39)
> > I've merged the PRs in our repo, if a follow-up is required just let me know.
> 
> We shouldn't have merged this. As comment 41 states, this doesn't entirely
> work.
> 

My bad, we wanted to do a test on whether this approach worked and as it was our repo we believe it was harmless.

> We now have the notes packaged app available anyways, so let's just get a
> followup PR to get that in there.

Comment 51

[Julien Wajsberg [:julienw]]

Comment on attachment 750841 [details]
pull request: https://github.com/telefonicaid/firefoxos-gaia-spain/pull/21

looks good to me, works on the device, and pass my hardening patch in Bug 862418.

so r=me

(sadly had to reset my dogfooding phone, ;) )

Comment 52

[Julien Wajsberg [:julienw]]

However it triggers Bug 850218 for me, does it for you too ? Shouldn't prevent from merging, as this is an already tracked other bug, but it's work mentioning it.

Comment 53

[[:fabrice] Fabrice Desré]

This PR still has notes.appcache instead of manifest.appcache. As I said already twice, this can't work is you don't fix that.

Comment 54

[Jason Smith [:jsmith]]

(In reply to Fabrice Desré [:fabrice] from comment #53)
> This PR still has notes.appcache instead of manifest.appcache. As I said
> already twice, this can't work is you don't fix that.

I don't follow. The updated PR removes all remnants of appcache referencing, given that we're switching to a packaged app here. Are you seeing something here that I'm not seeing?

Comment 55

[[:fabrice] Fabrice Desré]

(In reply to Jason Smith [:jsmith] from comment #54)
> (In reply to Fabrice Desré [:fabrice] from comment #53)
> > This PR still has notes.appcache instead of manifest.appcache. As I said
> > already twice, this can't work is you don't fix that.
> 
> I don't follow. The updated PR removes all remnants of appcache referencing,
> given that we're switching to a packaged app here. Are you seeing something
> here that I'm not seeing?

Hm, you're right. Looks like my repo is broken...

Comment 56

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

accroding Julien & Fabrice comments, I filed two issues on preload github repository for adding newline in end of metadata.json and *.webapp & change cache directory to manifest.appcache.

- https://github.com/yurenju/gaia-preload-app/issues/24
- https://github.com/yurenju/gaia-preload-app/issues/25

but I'll merge this bug first for tef+

Comment 57

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Merged.

Spain:
https://github.com/telefonicaid/firefoxos-gaia-spain/commit/477b1e415bd30390e7cdfe9b2e4c375cbd3f298d

latam:
https://github.com/telefonicaid/firefoxos-gaia-latam/commit/ed1459a6d35b75b916614f35da9578d960c636dc

Comment 58

[sarsenyev]

Attachment: Prio Note app screenshot attachment

The same issue with Prio Note app from Marketplace,
The app is required network connection on the first launch

Tested on Inari V1.0.1 and Unagi V1.1 device
Unagi:
Environmental  Variables:
Build ID: 20130620230208
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/a34f6d62cb05
Gaia: de211a86e1df621415942e8b02acea77efafd864
Platform Version: 18.0

Inari:
Environmental  Variables:
Build ID: 20130621070204
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/9c62297d11b0
Gaia: 93241eb6c5d6c110710fad8da3ccd4423312b0c9
Platform Version: 18.0

Comment 59

[Julien Wajsberg [:julienw]]

Please file a new bug for this, thanks !