866748 - nsIWebProgress::isTopLevel shouldn't throw

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

See bug 732593. It should just return false in the cases where there is no window.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

I left exceptions/warnings for what AFAICT should be quite exceptional cases (do_QueryInterface or GetTop failing), but I guess I could remove those as well.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/16c6e8f4dc2f

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: fixed patch

That was backed out because I failed to actually compile the change before pushing it (thought I had, but I was foiled by CLOBBER and didn't notice).

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/49976a593558

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Well, at least it compiled this time. Backed out for mochitest asserts, though.
https://hg.mozilla.org/integration/mozilla-inbound/rev/598cfd4cb5eb

https://tbpl.mozilla.org/php/getParsedLog.php?id=22411612&tree=Mozilla-Inbound

Comment 6

[:Gavin Sharp [email: [e-mail]]]

From IRC, RyanVM says I was blamed incorrectly!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Yep, sorry about that.
https://hg.mozilla.org/integration/mozilla-inbound/rev/1936616a7f41

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1936616a7f41