Closed Bug 866778 Opened 7 years ago Closed 7 years ago

GC: Make autorooter for HashableValue contain its value

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(1 file)

Attached patch Proposed changesSplinter Review
Change HashableValue::AutoRooter to AutoHashableValueRooter and make it contain its HashableValue rather than a pointer to it.  This fixes the rooting hazards reported in MapObject.cpp
Attachment #743145 - Flags: review?(sphink)
Comment on attachment 743145 [details] [diff] [review]
Proposed changes

Review of attachment 743145 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/gc/RootMarking.cpp
@@ +626,2 @@
>  {
> +    MarkValueRoot(trc, reinterpret_cast<Value*>(&value), "HashableValue::AutoRooter");

doc string should be "AutoHashableValueRooter" now
Attachment #743145 - Flags: review?(sphink) → review+
https://hg.mozilla.org/mozilla-central/rev/41b415cfb860
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.