866867 - test_spdy.js flaky with speculative connections

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, minor)

Description

[Patrick McManus [:mcmanus]]

test_spdy.js relies on a synchronous xhr at the start of the script to allow install a cert exception that the spdy tests rely on. Speculative connections can result in in some parallelism and out of order connection reuse - which in turn can make later tests fail that were depending on the exception being installed.

865314 removes a restriction that makes the initial ssl handshake with a host happen in serial and that in turn makes the spdy test go intermittent orange.

we can fix this just by disabling speculative connections during the xhr setup portion of this test.

https://tbpl.mozilla.org/?tree=Try&rev=5a5a844301bb

Comment 1

[Patrick McManus [:mcmanus]]

Attachment: patch 0

Comment 2

[u408661]

Comment on attachment 743228 [details] [diff] [review]
patch 0

Review of attachment 743228 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me

Comment 3

[Patrick McManus [:mcmanus]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/360472327b09

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/360472327b09