866916 - JavaScript JS_MORE_DETERMINISTIC builds are busted

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: stack

JavaScript JS_MORE_DETERMINISTIC builds are busted, see stack. It wasn't broken last week.

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Bug 634839, or https://hg.mozilla.org/mozilla-central/rev/9ab1119d4596#l26.37 broke this.

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Double confirmed:

autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   130017:9ab1119d4596
user:        Nicholas Nethercote
date:        Tue Apr 23 23:44:36 2013 -0700
summary:     Bug 634839 (part 1) - Remove unnecessary headers (as found by include-what-you-use) from js/src/jsfoo.cpp files.  r=luke.

Comment 3

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: patch v1

Comment 4

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: patch v2 - ifdefs are unnecessary

Removed the ifdef as recommended by sfink in-person, ifdefs are ugly.

Comment 5

[Steve Fink [:sfink] [:s:]]

Comment on attachment 743305 [details] [diff] [review]
patch v2 - ifdefs are unnecessary

Review of attachment 743305 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay. Rebuilding my computer.

Comment 6

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e963546ec749

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e963546ec749